appveyor: Script improvement part II #14665

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:appveyor-quiet changing 1 files +9 −16
  1. ken2812221 commented at 3:03 AM on November 6, 2018: contributor
    • decrease clone depth to 5
    • Upgrade to python 3.7 that we can use PYTHONUTF8 from PEP540.
    • Set clcache version to v4.2.0
    • Do not fetch the latest vcpkg package (The issue does not exist anymore)
    • Set test_bitcoin report sink and log sink to stdout and redirect stderr to NUL to drop confusing error messages that introduced by #14146
    • discard vcpkg, bench_bitcoin output
    • Set functional test --failfast flag
    • Make the log be as clear as possible. (Only ~100 lines)
  2. appveyor: Script improvement part II 99d33a6bec
  3. fanquake added the label Tests on Nov 6, 2018
  4. DrahtBot commented at 5:29 AM on November 6, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14372 (msvc: build secp256k1 and leveldb locally by ken2812221)
    • #13787 (Test for Windows encoding issue by ken2812221)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke assigned NicolasDorier on Nov 6, 2018
  6. MarcoFalke unassigned NicolasDorier on Nov 6, 2018
  7. MarcoFalke commented at 3:50 PM on November 6, 2018: member
  8. NicolasDorier commented at 4:03 PM on November 6, 2018: contributor

    quick review ACK, but will test tomorrow.

  9. sipsorcery commented at 7:23 AM on November 7, 2018: member

    tACK 99d33a6becd9dc2e8e846f85c9567baf0ebddb64

    First build with the updated yaml file failed on the wallet_multiwallet.py test but the two subsequent builds passed. This is most likely a vagary of AppVeyor.

  10. MarcoFalke referenced this in commit 4e6dc7a0ef on Nov 7, 2018
  11. MarcoFalke merged this on Nov 7, 2018
  12. MarcoFalke closed this on Nov 7, 2018

  13. ken2812221 deleted the branch on Nov 7, 2018
  14. in .appveyor.yml:54 in 99d33a6bec
      49 | @@ -57,9 +50,9 @@ before_test:
      50 |  - ps:  '[IO.File]::WriteAllLines([IO.Path]::Combine(${env:APPVEYOR_BUILD_FOLDER}, "test", "config.ini"), ${conf_ini}, ${utf8})'
      51 |  - ps:  move "build_msvc\${env:PLATFORM}\${env:CONFIGURATION}\*.exe" src
      52 |  test_script:
      53 | -- cmd: src\test_bitcoin.exe
      54 | -- ps:  src\bench_bitcoin.exe -evals=1 -scaling=0
      55 | +- cmd: src\test_bitcoin.exe -k stdout -e stdout 2> NUL
      56 | +- cmd: src\bench_bitcoin.exe -evals=1 -scaling=0 > NUL
    


    MarcoFalke commented at 7:35 PM on December 17, 2018:

    This will hide precious debug information in case of failure?

    See for example https://github.com/bitcoin/bitcoin/pull/14955/commits/1a7cebc1cdd3c8fb8751fd21c782679081397ae2


    sipa commented at 9:26 PM on December 17, 2018:

    @MarcoFalke No, it doesn't seem to. -k stdout is supposed to send the output to stdout anyway. I was just making sure that wasn't the problem.

  15. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me