qt: Revert "Force TLS1.0+ for SSL connections" (0.17) #14666

1. 
   laanwj commented at 8:06 AM on November 6, 2018: member

   backports #14403 which fixes a crash on FC29

2. qt: Revert "Force TLS1.0+ for SSL connections"

   This reverts commit 15e26a6a9afe299b9ca6fced73b876644365879b, whose
   purpose was to tweak the Qt configuration to force TLS, i.e., to
   disable SSLv3, in Qt versions >= 5.5. However, the default behavior
   of Qt >= 5.4 is to disable SSLv3 anyway [1], so the configuration
   tweak is redundant.
   
   With Qt 5.11.2, the configuration tweak is not only redundant but in
   fact provokes a deadlock (#14359) due to Qt 5.11.2 being incompatible
   with OpenSSL 1.1.1 [2]. Since the deadlock occurs at the early startup
   stage of bitcoin-qt, it renders bitcoin-qt entirely non-functional
   when compiled against OpenSSL 1.1.1 and Qt 5.11.2 (and possible future
   combinations of OpenSSL and Qt versions).
   
   This commit fixes #14359 by removing the redundant code.
   
   [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3fd2d9eff8c1f948306ee5fbfe364ccded1c4b84
   [2] https://bugreports.qt.io/browse/QTBUG-70956
   
   Github-Pull: #14403
   Rebased-From: 7d173c4cd1885ff5bcf9e5f8f7f712138dd8a445
   Tree-SHA512: 71a34b13202c834c5ca73bcb9b70efff26c34e1aac3b954f098620b62c2be53a8e319929c4764a5b5cc5d0dd163ff70f4eb3a4f1f608363b7d23d1b16b25ddc7

   0242b5afa4
3. laanwj added the label GUI on Nov 6, 2018
4. laanwj added the label Backport on Nov 6, 2018
5. laanwj renamed this:
   qt: Revert "Force TLS1.0+ for SSL connections"
   qt: Revert "Force TLS1.0+ for SSL connections" (0.17)
   on Nov 6, 2018
6. fanquake added this to the milestone 0.17.1 on Nov 6, 2018
7. 
   meshcollider commented at 8:13 AM on November 6, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14666/commits/0242b5afa4ebb381d3a59a7246348a50d3a7fdbe

8. 
   wtogami commented at 8:13 AM on November 6, 2018: contributor

   Tested ACK on Fedora 29 x86_64 0242b5afa4ebb381d3a59a7246348a50d3a7fdbe

9. laanwj merged this on Nov 6, 2018
10. laanwj closed this on Nov 6, 2018

    ---

11. laanwj referenced this in commit b0e88b8914 on Nov 6, 2018
12. MarcoFalke locked this on Sep 8, 2021

Contributors

laanwjmeshcolliderwtogami

Milestone
0.17.1