URITests : failing unit test #1468

********* Start testing of URITests ********* Config: Using QTest library 4.7.4, Qt 4.7.4 PASS : URITests::initTestCase() FAIL! : URITests::uriTests() 'GUIUtil::parseBitcoinURI(uri, &rv)' returned FALSE. () Loc: [src/qt/test/uritests.cpp(24)] PASS : URITests::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped ********* Finished testing of URITests *********

To get the unit tests compiling I had to:

diff --git a/src/qt/test/uritests.cpp b/src/qt/test/uritests.cpp index 70c20be..86936d4 100644 --- a/src/qt/test/uritests.cpp +++ b/src/qt/test/uritests.cpp @@ -47,7 +47,7 @@ void URITests::uriTests() uri.setUrl(QString("bitcoin:175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W?amount=100&label=Wikipedia Example")); QVERIFY(GUIUtil::parseBitcoinURI(uri, &rv)); QVERIFY(rv.address == QString("175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W"));

• QVERIFY(rv.amount == 10000000000);
• QVERIFY(rv.amount == 10000000000LL); QVERIFY(rv.label == QString("Wikipedia Example"));

uri.setUrl(QString("bitcoin:175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W?message=Wikipedia Example Address"));

Huh, how can that have passed for so long?

Passes now, closing

********* Start testing of URITests *********
Config: Using QTest library 4.8.1, Qt 4.8.1
PASS   : URITests::initTestCase()
PASS   : URITests::uriTests()
PASS   : URITests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of URITests *********