Add new P2P command and response: "getcmds", "cmdlist" #1471

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:list-ops changing 1 files +30 −0
  1. jgarzik commented at 12:08 AM on June 16, 2012: contributor

    This lists the capabilities of the remote node, in the form of a vector<string> list of commands advertised by remote node.

  2. Add new P2P command and response: "getcmds", "cmdlist"
    This lists the capabilities of the remote node, in the form of a
    vector<string> list of commands advertised by remote node.
    aa412d4e18
  3. laanwj commented at 6:38 AM on June 16, 2012: member

    What's up with adding all the P2P commands lately? Shouldn't this be discussed in a BIP?

    Personally I still think it's better to have a clear standardized "protocol version", that implies what capabilities are supported, instead of a capability-based system that explicitly lists them.

    Capability-based systems tend to become horrendously complex, as you have to take into account all possible combinations of possible interactions, and constantly check for support of specific features instead of just comparing a version number.

  4. Diapolo commented at 9:09 AM on June 16, 2012: none

    @laanwj ACK

  5. jgarzik commented at 12:54 PM on June 16, 2012: contributor

    No, you don't discuss things in a BIP. You first implement the code, then discuss on the mailing list and forums.

  6. laanwj commented at 1:38 PM on June 16, 2012: member

    Yes I meant describe in a BIP.

  7. luke-jr commented at 10:00 PM on June 18, 2012: member

    @jgarzik Well, FWIW, @gavinandresen is always saying to discuss on the mailing list before making pull requests...

    But this whole thread of discussion is IMO off-topic for here...

  8. jgarzik commented at 3:52 PM on June 27, 2012: contributor

    Closing, not sufficient consensus or interest, based on mailing list discussion

  9. jgarzik closed this on Jun 27, 2012

  10. jgarzik deleted the branch on Aug 24, 2014
  11. lateminer referenced this in commit 617fd9998c on Jan 22, 2019
  12. lateminer referenced this in commit 7fdf25b4f7 on May 6, 2020
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 00:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me