Tests: Fix running wallet_listtransactions.py individually through test_runner.py #14738

pull kristapsk wants to merge 1 commits into bitcoin:master from kristapsk:listtransactions changing 2 files +8 −18

kristapsk commented at 6:42 PM on November 16, 2018: contributor

As suggested by @MarcoFalke. Resolves #14732.
MarcoFalke commented at 6:46 PM on November 16, 2018: member

(en|dis)able_mocktime is now only used for the create_cache util function. Mind inlining it there to make sure it is not called from the outside again?
kristapsk force-pushed on Nov 16, 2018
kristapsk commented at 7:01 PM on November 16, 2018: contributor

Done.

in test/functional/test_framework/test_framework.py:444 in 8f4bd562cd outdated

 439 | +            # mocktime may be needed for scripts that use the cached version of the
 440 | +            # blockchain.  If the cached version of the blockchain is used without
 441 | +            # mocktime then the mempools will not sync due to IBD.
 442 | +            #
 443 | +            # For backward compatibility of the python scripts with previous
 444 | +            # versions of the cache, this helper function sets mocktime to Jan 1,

MarcoFalke commented at 7:06 PM on November 16, 2018:

            # versions of the cache, set mocktime to Jan 1,

in test/functional/test_framework/test_framework.py:441 in 8f4bd562cd outdated

 433 | @@ -451,14 +434,24 @@ def _initialize_chain(self):
 434 |              for node in self.nodes:
 435 |                  node.wait_for_rpc_connection()
 436 |  
 437 | +            # Enable mocktime for the script.
 438 | +            #
 439 | +            # mocktime may be needed for scripts that use the cached version of the
 440 | +            # blockchain.  If the cached version of the blockchain is used without
 441 | +            # mocktime then the mempools will not sync due to IBD.

MarcoFalke commented at 7:07 PM on November 16, 2018:

Remove those two comments?

in test/functional/test_framework/test_framework.py:389 in 8f4bd562cd outdated

 384 | -        self.mocktime = 1388534400 + (201 * 10 * 60)
 385 | -
 386 | -    def disable_mocktime(self):
 387 | -        self.mocktime = 0
 388 | -
 389 | -    # Private helper methods. These should not be accessed by the subclass test scripts.

MarcoFalke commented at 7:07 PM on November 16, 2018:

Should not touch this comment?

MarcoFalke approved
MarcoFalke commented at 7:08 PM on November 16, 2018: member

ACK, beside comments
Fix running individually through test_runner.py, as suggested by @MarcoFalke (#14732) 2474de0265
kristapsk force-pushed on Nov 16, 2018
kristapsk commented at 8:27 PM on November 16, 2018: contributor

Ok, changed comments too.
fanquake added the label Tests on Nov 16, 2018
MarcoFalke commented at 5:09 PM on November 17, 2018: member

utACK 2474de02650b97e14c4f3330dd04add1b84347b6
kristapsk renamed this:
~~Fix running wallet_listtransactions.py individually through test_runner.py~~
Tests: Fix running wallet_listtransactions.py individually through test_runner.py
on Nov 22, 2018
MarcoFalke referenced this in commit 96d912bea8 on Dec 29, 2018
MarcoFalke merged this on Dec 29, 2018
MarcoFalke closed this on Dec 29, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

kristapsk

MarcoFalke

Labels

Tests

Linked (view graph)

#14732 test/functional/test_runner.py wallet_listtransactions.py fails when run individually