Remove filesystem/fstream from EXPECTED_BOOST_INCLUDES #14763

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2018/11/expected_boost_includes changing 1 files +0 −1

Sjors commented at 7:29 PM on November 19, 2018: member

#14718 caused the Travis linter machine to fail due to:

test/lint/lint-includes.sh
Good job! The Boost dependency "boost/filesystem/fstream.hpp" is no longer used.
Please remove it from EXPECTED_BOOST_INCLUDES in test/lint/lint-includes.sh
to make sure this dependency is not accidentally reintroduced.

build: remove filesystem/fstream from EXPECTED_BOOST_INCLUDES 9ca5d4bf8a
meshcollider commented at 7:40 PM on November 19, 2018: contributor

utACK

Sjors commented at 7:41 PM on November 19, 2018: member

Travis not happy:

In file included from bitcoind.cpp:13:0:
./fs.h:89:17: error: ‘ifstream’ in namespace ‘fs’ does not name a type
     typedef fs::ifstream ifstream;
                 ^
./fs.h:90:17: error: ‘ofstream’ in namespace ‘fs’ does not name a type
     typedef fs::ofstream ofstream;
                 ^
Makefile:8901: recipe for target 'bitcoind-bitcoind.o' failed

meshcollider added the label Scripts and tools on Nov 19, 2018
MarcoFalke commented at 7:55 PM on November 19, 2018: member

Hmm :( The one time you needed travis, it wasn't running.
MarcoFalke commented at 7:56 PM on November 19, 2018: member

I compiled locally, but if travis doesn't like it, please just revert https://github.com/bitcoin/bitcoin/pull/14718/files#diff-ef73d49954ee42b794bd5129a406a8b5L15
kallewoof commented at 5:37 AM on November 20, 2018: member
Yeah, looks like you need
```
#include <boost/filesystem/fstream.hpp>
```
in fs.h for some architectures (e.g. Debian Jessie PPC).
meshcollider commented at 5:50 AM on November 20, 2018: contributor

Closing in favour of #14768
meshcollider closed this on Nov 20, 2018
laanwj referenced this in commit 1b99d153d0 on Nov 20, 2018
Sjors deleted the branch on Nov 20, 2018
Munkybooty referenced this in commit 5ee0ec4f56 on Jul 29, 2021
Munkybooty referenced this in commit eba469e3b0 on Aug 3, 2021
Munkybooty referenced this in commit eb9a3965c3 on Aug 5, 2021
Munkybooty referenced this in commit 526fb543ca on Aug 8, 2021
Munkybooty referenced this in commit e1c365e257 on Aug 9, 2021
Munkybooty referenced this in commit de5d8af15d on Aug 11, 2021
5tefan referenced this in commit 6e92792f59 on Aug 12, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#14718 Remove unreferenced boost headers #14768 revert removal of fstream.hpp header in fs.h