This PR would wait until the .cookie file is readable
Possible fix no. 5 PermissionError in #14446
tests: Possible fix the permission error when the tests open the cookie file #14788
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:fix-win-test-perm-deny changing 1 files +1 −1-
ken2812221 commented at 8:08 PM on November 22, 2018: contributor
-
MarcoFalke commented at 8:49 PM on November 22, 2018: member
utACK 0cb4518d355738b2530a66cded2fc4b673ba1c2a
- MarcoFalke added the label Tests on Nov 22, 2018
-
laanwj commented at 6:55 AM on November 23, 2018: member
There's so much polling and waiting in the tests; from a determinism point of view I'd prefer to do this waiting once after starting a node, this is the only time where one'd expect the cookie to possibly not be there yet (maybe make it part of the current poll-after-run loop).
(If the same happens and it's trying to find the cookie after shutdown this is a problem with the test and it shouldn't simply wait 10 seconds. Or if the cookie goes missing while a node is supposed to be running this is a problem with the software that should be detected immediately.)
-
promag commented at 3:19 PM on November 23, 2018: member
-
tests: check readability of cookie file d6b3790d1a
- ken2812221 force-pushed on Nov 23, 2018
-
ken2812221 commented at 6:35 PM on November 23, 2018: contributor
@laanwj Now it would also raise ValueError if the cookie file is not readable. It can be caught in
wait_for_rpc_connection() -
MarcoFalke commented at 5:47 PM on December 6, 2018: member
utACK d6b3790d1a41030f4ac83556fdbe9f019b9b4e59
- MarcoFalke merged this on Dec 7, 2018
- MarcoFalke closed this on Dec 7, 2018
- MarcoFalke referenced this in commit 2753285be7 on Dec 7, 2018
- ken2812221 deleted the branch on Dec 8, 2018
- Munkybooty referenced this in commit bb975fbc84 on Aug 2, 2021
- Munkybooty referenced this in commit b9b5e75962 on Aug 3, 2021
- Munkybooty referenced this in commit bac4b6dc77 on Aug 5, 2021
- Munkybooty referenced this in commit 6a1747bb5e on Aug 5, 2021
- Munkybooty referenced this in commit 563ad654c4 on Aug 8, 2021
- Munkybooty referenced this in commit 7bbd22c68d on Aug 11, 2021
- Munkybooty referenced this in commit f089273ed0 on Aug 11, 2021
- Munkybooty referenced this in commit b92a8c2019 on Aug 13, 2021
- Munkybooty referenced this in commit 29ba5a37de on Aug 15, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels