doc: clarify RPC rawtransaction documentation #14808

pull jlopp wants to merge 1 commits into bitcoin:master from jlopp:RPCHelpTypo changing 1 files +2 −2

jlopp commented at 3:04 PM on November 26, 2018: contributor

Fixing an RPC documentation typo and clarifying the wording of the testmempoolaccept function.
clarify RPC rawtransaction documentation 848077f94d
kristapsk commented at 3:09 PM on November 26, 2018: contributor

utACK 848077f94de001579d5c04df6198d110c68bf24b

in src/rpc/rawtransaction.cpp:942 in 848077f94d

 938 | @@ -939,7 +939,7 @@ static UniValue signrawtransactionwithkey(const JSONRPCRequest& request)
 939 |                  "this transaction depends on but may not yet be in the block chain.\n",
 940 |                  {
 941 |                      {"hexstring", RPCArg::Type::STR, false},
 942 | -                    {"privkyes", RPCArg::Type::ARR,
 943 | +                    {"privkeys", RPCArg::Type::ARR,

promag commented at 3:15 PM on November 26, 2018:

Reported by @kewde http://www.erisian.com.au/bitcoin-core-dev/log-2018-11-26.html#l-139.

MarcoFalke commented at 4:19 PM on November 26, 2018:

Good catch. Currently the argument names of arrays are not used in any way to produce the string by RPCHelpMan, only after #14796.

promag commented at 3:16 PM on November 26, 2018: member

utACK 848077f.
DrahtBot commented at 4:03 PM on November 26, 2018: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14796 (rpc: Pass argument descriptions to RPCHelpMan by MarcoFalke)
- #14459 (More RPC help description fixes by ch4ot1c)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke added the label Docs on Nov 26, 2018
MarcoFalke approved
MarcoFalke renamed this:
~~clarify RPC rawtransaction documentation~~
doc: clarify RPC rawtransaction documentation
on Nov 26, 2018
MarcoFalke merged this on Nov 26, 2018
MarcoFalke closed this on Nov 26, 2018
MarcoFalke referenced this in commit b5c3d7affc on Nov 26, 2018
jlopp deleted the branch on Nov 26, 2018
jasonbcox referenced this in commit 406d1a2145 on Oct 26, 2020
vijaydasmp referenced this in commit 5844b53515 on Sep 6, 2021
vijaydasmp referenced this in commit 9bdaa0bf3a on Sep 6, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

doc: clarify RPC rawtransaction documentation #14808

Conflicts