Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize #14819

1. 
   luke-jr commented at 5:57 PM on November 27, 2018: member

   Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size. Use math.ceil to ensure the transaction is always oversize.

   (This issue can be triggered by changing the address style used.)

2. Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize

   Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size.
   Use math.ceil to ensure the transaction is always oversize.

   29aeed1734
3. MarcoFalke added this to the milestone 0.18.0 on Nov 27, 2018
4. 
   MarcoFalke commented at 7:03 PM on November 27, 2018: member

   utACK 29aeed1734793d4bc50174d1837393581a234ee6 (I think I left it out back then because it was working already without the math import)

5. fanquake added the label Tests on Nov 27, 2018
6. in test/functional/mempool_accept.py:8 in 29aeed1734

      4 | @@ -5,6 +5,7 @@
      5 |  """Test mempool acceptance of raw transactions."""
      6 |  
      7 |  from io import BytesIO
      8 | +import math
   

   ---

   ---

   

   promag commented at 10:51 AM on November 28, 2018:

   nit from math import ceil?

7. 
   promag commented at 10:57 AM on November 28, 2018: member

   utACK 29aeed1.

8. MarcoFalke merged this on Nov 28, 2018
9. MarcoFalke closed this on Nov 28, 2018

   ---

10. MarcoFalke referenced this in commit 9ebfe0e927 on Nov 28, 2018
11. UdjinM6 referenced this in commit 279a87028f on May 21, 2021
12. UdjinM6 referenced this in commit 3c78078211 on May 21, 2021
13. UdjinM6 referenced this in commit da28b04622 on May 21, 2021
14. UdjinM6 referenced this in commit 31e0fb550f on May 22, 2021
15. kittywhiskers referenced this in commit 463f6ac015 on May 25, 2021
16. DrahtBot locked this on Sep 8, 2021

Milestone
0.18.0