GUI: ensure a changed bitcoin unit immediately updates the tx list amounts #1483

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:txtablemodel_updateDisplayUnit changing 2 files +8 −0

Diapolo commented at 8:51 PM on June 18, 2012: none

This is kind of an addition to #1434 and fixes #1482.

in src/qt/transactiontablemodel.cpp:None in 21e1e0dc12 outdated

 625 | @@ -624,3 +626,8 @@ QModelIndex TransactionTableModel::index(int row, int column, const QModelIndex
 626 |      }
 627 |  }
 628 |  
 629 | +void TransactionTableModel::updateDisplayUnit()
 630 | +{
 631 | +    // emit dataChanged to update Amount row with the current unit

laanwj commented at 5:09 PM on June 19, 2012:

Amount column :)

Diapolo commented at 5:11 PM on June 19, 2012:

Ouch ^^, will be fixed later, I'm off now for a few hours.

laanwj commented at 5:09 PM on June 19, 2012: member

ACK (except for the comment)
GUI: ensure a changed bitcoin unit immediately updates the tx list amounts 229c34f818

in src/qt/transactiontablemodel.cpp:None in 229c34f818

 625 | @@ -624,3 +626,8 @@ QModelIndex TransactionTableModel::index(int row, int column, const QModelIndex
 626 |      }
 627 |  }
 628 |  
 629 | +void TransactionTableModel::updateDisplayUnit()
 630 | +{
 631 | +    // emit dataChanged to update Amount column with the current unit

Diapolo commented at 4:52 AM on June 20, 2012:

Fixed :)!

laanwj referenced this in commit 703db97d80 on Jun 20, 2012
laanwj merged this on Jun 20, 2012
laanwj closed this on Jun 20, 2012
coblee referenced this in commit fef9c2e119 on Jul 17, 2012
suprnurd referenced this in commit adf97e12ab on Dec 5, 2017
lateminer referenced this in commit f0a7354a95 on Jan 22, 2019
lateminer referenced this in commit f79a7026d0 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#1434 GUI: init with correct display unit and update it, when user changes it via options dialog #1482 Transactions amounts don't update when unit change is Apply'd #25824 UndefinedBehaviorSanitizer: stack-overflow in miniscript (descriptor_parse)