refactor: SHA256AutoDetect dead stores #14847

pull kallewoof wants to merge 3 commits into bitcoin:master from kallewoof:20181129-sha256autodetect-deadstores changing 1 files +37 −28
  1. kallewoof commented at 1:04 AM on November 30, 2018: member

    A rewrite of the SHA256AutoDetect function with some macroing to conditionally declare variables only if they are actually going to be used.

    This removes multiple static analyzer complaints about dead stores (variables given a value and then discarded without reading the value ever).

    It is also a slight clean-up as the (void)var; hacks are no longer necessary.

  2. refactor: SHA256AutoDetect() AVX2 case only tested if AVX enabled 4c6d6c7e72
  3. refactor: SHA256AutoDetect() SHANI case only tested if SHANI enabled 6973d023a5
  4. kallewoof renamed this:
    refactor: SHA256Autodetect dead stores
    refactor: SHA256AutoDetect dead stores
    on Nov 30, 2018
  5. sipa commented at 1:08 AM on November 30, 2018: member

    This seems a lot uglier than the existing (void)var; statements.

  6. f'reduce macro use b89468bc6d
  7. kallewoof commented at 1:14 AM on November 30, 2018: member

    Made it a bit less ugly. Will see about making it even less so..

  8. fanquake added the label Refactoring on Nov 30, 2018
  9. DrahtBot commented at 5:44 AM on November 30, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #13989 (add avx512 instrinsic by fingera)
    • #13442 (Convert the 1-way SSE4 SHA256 code from asm to intrinsics by sipa)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. kallewoof closed this on Nov 30, 2018

  11. kallewoof deleted the branch on Nov 30, 2018
  12. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me