Small logical error in mruset #1485

pull xanatos wants to merge 1 commits into bitcoin:master from xanatos:patch-1 changing 1 files +1 −1

xanatos commented at 6:50 AM on June 19, 2012: none

As written if you make a new_size(10) the mruset will be reduced to up to 9 elements (the while will exit when !(queue.size() >= 10) so (queue.size() < 10).

This "feature" of reducing the mruset length isn't used, so the impact on the program should be zero.
If (for example) the new max_size must be 5 then at the end the queue.size() must be <= 5, so the exit condition must be <=, so the continuing condition must be > (and not >= as it was). 16d5671943
sipa referenced this in commit 451c3957fe on Jun 19, 2012
sipa merged this on Jun 19, 2012
sipa closed this on Jun 19, 2012
coblee referenced this in commit 6e7a1017da on Jul 17, 2012
suprnurd referenced this in commit 72fbfe93d8 on Dec 5, 2017
lateminer referenced this in commit ef6bbfd0ad on Jan 22, 2019
lateminer referenced this in commit 44307cc45d on Jan 22, 2019
lateminer referenced this in commit d43d5fa1f6 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors