tests: Modify rpc_bind to conform to #14532 behaviour. #14861

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2018-12-fix-rpc-bind-tests changing 1 files +7 −4

dongcarl commented at 5:18 PM on December 3, 2018: member

Fixes: https://github.com/bitcoin/bitcoin/issues/14792
dongcarl renamed this:
~~tests: Modify rpc_bind to conform to #14532 behaviour.~~
[WIP] tests: Modify rpc_bind to conform to #14532 behaviour.
on Dec 3, 2018
MarcoFalke added the label Tests on Dec 3, 2018
MarcoFalke commented at 6:26 PM on December 3, 2018: member

Concept ACK

tests: Modify rpc_bind to conform to #14532 behaviour.

- Even when rpcallowip is specified, only bind localhost
- Explicitly bind in run_allowip_test

f3cf95ffdf

dongcarl force-pushed on Dec 3, 2018
dongcarl renamed this:
~~[WIP] tests: Modify rpc_bind to conform to #14532 behaviour.~~
tests: Modify rpc_bind to conform to #14532 behaviour.
on Dec 3, 2018
dongcarl commented at 6:38 PM on December 3, 2018: member

All tests should pass now. Ready for review.
laanwj commented at 9:26 AM on December 4, 2018: member

tested ACK f3cf95ffdfda935f28260eb34bf20c1449a200c5
laanwj merged this on Dec 4, 2018
laanwj closed this on Dec 4, 2018
laanwj referenced this in commit abbf4be181 on Dec 4, 2018
deadalnix referenced this in commit 71030e6af4 on Apr 29, 2020
UdjinM6 referenced this in commit 8fd4c5ad80 on Jul 9, 2020
UdjinM6 referenced this in commit e7a730f7af on Jul 9, 2020
UdjinM6 referenced this in commit fcd3029090 on Jul 12, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels