RFC: rpc: Support time specifiers in dumpwallet filename #14887

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-12-dumpwallet-time changing 2 files +8 −4
  1. promag commented at 3:59 PM on December 6, 2018: member

    Support strftime specifiers in dumpwallet filename.

    Example:

    bitcoin-cli -regtest dumpwallet "/tmp/wallet_%Y%m%d_%H%M%S.bak"
    
    {
      "filename": "/tmp/wallet_20181206_155742.bak"
    }
    

    See http://www.cplusplus.com/reference/ctime/strftime/.

    Follow up of #9937.

  2. rpc: Support time specifiers in dumpwallet filename adba4e40f6
  3. promag force-pushed on Dec 6, 2018
  4. DrahtBot commented at 6:44 PM on December 6, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14599 (Use functions guaranteed to be locale independent (IsDigit, ToLower) in {Format,Parse}Money(...), uint256::SetHex(...), etc. Remove the use of locale dependent boost::is_space(...) by practicalswift)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. fanquake added the label RPC/REST/ZMQ on Dec 6, 2018
  6. promag commented at 9:34 PM on December 6, 2018: member

    The client can also build the final path.. :roll_eyes:

  7. MarcoFalke commented at 9:37 PM on December 6, 2018: member

    Yeah, seems like unnecessary complexity to pull in

  8. promag commented at 9:56 PM on December 6, 2018: member

    Agree.

  9. promag closed this on Dec 6, 2018

  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me