travis: fix travis would always be green even if it fail #14937

1. 
   ken2812221 commented at 5:00 PM on December 12, 2018: contributor

   The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.

   This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.

   Sorry for ruin the travis ci system in #14231

   Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010

2. fanquake added the label Tests on Dec 12, 2018
3. MarcoFalke added this to the milestone 0.18.0 on Dec 12, 2018
4. 
   MarcoFalke commented at 5:45 PM on December 12, 2018: member

   Fine with me, but maybe it is not worth the code complexity in the travis yaml to support saving the cache in case of a test (or compile) failure?

5. 
   laanwj commented at 10:51 AM on December 13, 2018: member

   Fine with me, but maybe it is not worth the code complexity in the travis yaml to support saving the cache in case of a test (or compile) failure?

   I think that's a good point.

   Also I think not saving the cache in cache of failure makes sense, can you be certain what the state of things is when there's a failure?

6. 
   ken2812221 commented at 1:17 PM on December 13, 2018: contributor

   Ok. Let's revert #14231

7. Revert "travis: Save cache on build error"

   This reverts commit d3ecc3d695f33d90d6c4e61f3d7ceb57f44eb200.

   fc91c1f28e
8. ken2812221 force-pushed on Dec 13, 2018
9. MarcoFalke referenced this in commit d88d1f8c2f on Dec 13, 2018
10. MarcoFalke merged this on Dec 13, 2018
11. MarcoFalke closed this on Dec 13, 2018

    ---

12. ken2812221 deleted the branch on Jan 22, 2019
13. PastaPastaPasta referenced this in commit 62443c9f86 on Sep 11, 2021
14. MarcoFalke locked this on Dec 16, 2021

Milestone
0.18.0