If we happen to pick the same random coin to spend, there would be mempool conflicts in some runs of the test. Fix that by popping from a static list of coins to spend from.
test: Fix race in mempool_accept #14964
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1812-testRaceMempoolAccept changing 1 files +3 −2-
MarcoFalke commented at 11:14 PM on December 14, 2018: member
-
test: Fix race in mempool_accept faee59103d
- MarcoFalke added the label Tests on Dec 14, 2018
- MarcoFalke added this to the milestone 0.18.0 on Dec 14, 2018
-
DrahtBot commented at 12:27 AM on December 15, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #14939 (rpc: Allow testmempoolaccept to test unsigned transactions by lontivero)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- ken2812221 approved
-
ken2812221 commented at 2:54 PM on December 17, 2018: contributor
utACK faee59103d8f5f2a5c91711d55c9a1f346593b33
-
promag commented at 3:03 PM on December 17, 2018: member
ACK faee591.
- MarcoFalke merged this on Dec 17, 2018
- MarcoFalke closed this on Dec 17, 2018
- MarcoFalke referenced this in commit b545a6e689 on Dec 17, 2018
- MarcoFalke deleted the branch on Dec 17, 2018
- christiancfifi referenced this in commit 9545dcae9c on Aug 24, 2021
- christiancfifi referenced this in commit f41004a283 on Aug 24, 2021
- christiancfifi referenced this in commit fc757cd868 on Aug 25, 2021
- christiancfifi referenced this in commit 696d39ed67 on Aug 26, 2021
- christiancfifi referenced this in commit 2c3284bf84 on Aug 28, 2021
- christiancfifi referenced this in commit 5b9f216b64 on Aug 29, 2021
- christiancfifi referenced this in commit b274f749eb on Aug 29, 2021
- christiancfifi referenced this in commit bcf6ff434e on Aug 29, 2021
- MarcoFalke locked this on Sep 8, 2021