qt: Refactoring with QString::toNSString() #14975

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181216-macos-shownotification-refactor changing 1 files +4 −19
  1. hebasto commented at 6:42 PM on December 16, 2018: member

    This PR makes MacNotificationHandler::showNotification() cleaner and more readable. The used QString::toNSString() function was introduced in Qt 5.2 which is minimum version now (#14725).

    The behavior of MacNotificationHandler::showNotification() has not been changed.

    cc: @jonasschnelli

  2. Refactoring with QString::toNSString
    The behavior of MacNotificationHandler::showNotification() has not been
changed.
    4d454dcb64
  3. fanquake added the label GUI on Dec 16, 2018
  4. fanquake added the label macOS on Dec 16, 2018
  5. MarcoFalke added the label Refactoring on Dec 17, 2018
  6. MarcoFalke added the label Needs gitian build on Dec 17, 2018
  7. laanwj commented at 12:06 PM on December 17, 2018: member

    nice cleanup utACK 4d454dcb64d6c85ab41be3da763dd4753ef057f3

  8. promag commented at 2:53 PM on December 17, 2018: member

    Tested ACK 4d454dc on macOS 10.14.1.

  9. fanquake requested review from jonasschnelli on Dec 17, 2018
  10. DrahtBot commented at 11:48 PM on December 17, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 34241716852df6ea6a3543822f3bf6f886519d4b (master):

    Gitian builds for commit e99c68ced48a1480d21aaebc63886d9a6b28012d (master and this pull):

  11. DrahtBot removed the label Needs gitian build on Dec 17, 2018
  12. hebasto commented at 3:59 AM on December 18, 2018: member

    Hmm... How is it possible that changes in macOS-related Objective-C code can alter Linux and Windows builds (as hashes are different)?

  13. jonasschnelli approved
  14. jonasschnelli commented at 5:52 AM on December 18, 2018: contributor

    Yes. Nice cleanup. The weak linking is no longer required since we don't support macOS older then 10.8 (where the Notification Center was introduced).

    utACK 4d454dcb64d6c85ab41be3da763dd4753ef057f3

  15. jonasschnelli merged this on Dec 18, 2018
  16. jonasschnelli closed this on Dec 18, 2018
  17. jonasschnelli referenced this in commit e7b88ecbc9 on Dec 18, 2018
  18. hebasto deleted the branch on Dec 18, 2018
  19. deadalnix referenced this in commit 97264f0770 on Oct 26, 2020
  20. PastaPastaPasta referenced this in commit ec5fb2d576 on Jun 27, 2021
  21. PastaPastaPasta referenced this in commit c79f2a2496 on Jun 28, 2021
  22. PastaPastaPasta referenced this in commit 7df0673541 on Jun 29, 2021
  23. PastaPastaPasta referenced this in commit 9f292ab585 on Jul 1, 2021
  24. PastaPastaPasta referenced this in commit 4b78ad84aa on Jul 1, 2021
  25. PastaPastaPasta referenced this in commit 7986942615 on Jul 1, 2021
  26. UdjinM6 referenced this in commit 7fff85f7cb on Jul 5, 2021
  27. PastaPastaPasta referenced this in commit fba2ab550e on Jul 8, 2021
  28. MarcoFalke locked this on Sep 8, 2021
Contributors
hebastolaanwjpromagDrahtBotjonasschnelli
Labels
GUIRefactoringmacOS
Linked (view graph)
#14725 qt: Bump the minimum Qt version to 5.2
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me