rpc: GetKeyOrigin check in getaddressinfo RPC #14977

1. 
   benthecarman commented at 9:47 PM on December 16, 2018: contributor

   #14682 Adds a check in the getaddressinfo RPC.

2. GetKeyOrigin check in getaddressinfo rpc fb94bc9415
3. fanquake added the label Wallet on Dec 16, 2018
4. fanquake added the label RPC/REST/ZMQ on Dec 16, 2018
5. fanquake requested review from Sjors on Dec 17, 2018
6. in src/wallet/rpcwallet.cpp:3672 in fb94bc9415

   3667 | @@ -3668,7 +3668,8 @@ UniValue getaddressinfo(const JSONRPCRequest& request)
   3668 |      }
   3669 |      if (meta) {
   3670 |          ret.pushKV("timestamp", meta->nCreateTime);
   3671 | -        if (!meta->hdKeypath.empty()) {
   3672 | +        KeyOriginInfo info;
   3673 | +        if (!meta->hdKeypath.empty() && pwallet->GetKeyOrigin(key_id, info)) {
   

   ---

   ---

   

   promag commented at 2:46 PM on December 17, 2018:

   Would be nice to have a test that fails without this change.

   ---

   

   benthecarman commented at 5:08 PM on December 17, 2018:

   That may be a better idea and just close this PR

7. benthecarman renamed this:
   GetKeyOrigin check in getaddressinfo RPC
   rpc: GetKeyOrigin check in getaddressinfo RPC
   on Dec 18, 2018
8. benthecarman closed this on Dec 18, 2018

   ---

9. benthecarman deleted the branch on Dec 29, 2018
10. MarcoFalke locked this on Sep 8, 2021

Contributors

benthecarmanpromag

Review Requested
Sjors