Add 'settxfee' RPC, to change TX fee setting at runtime #150

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:settxfee changing 1 files +18 −0

jgarzik commented at 10:54 PM on April 12, 2011: contributor

No description provided.
gavinandresen commented at 1:49 AM on April 14, 2011: contributor

Forum thread: http://www.bitcoin.org/smf/index.php?topic=5752.0
jgarzik commented at 4:57 AM on April 14, 2011: contributor

Removed ValidFee() check

in rpc.cpp:None in 0e014e0262 outdated

 475 | +    // Amount
 476 | +    int64 nAmount = 0;
 477 | +    if (params[0].get_real() != 0.0)
 478 | +        nAmount = AmountFromValue(params[0]);        // rejects 0.0 amounts
 479 | +
 480 | +    static CCriticalSection cs;

gavinandresen commented at 3:18 PM on April 15, 2011:

Why the critsect? "coding ahead" in anticipation of multithreaded RPC?

jgarzik commented at 5:14 PM on April 15, 2011: contributor

Yeah, trying to future proof it a bit. Can remove, if you really don't like that.
mikegogulski commented at 3:16 PM on May 9, 2011: none

This is good, since it sure beats restarting bitcoind. But.. I'm going to open a new issue.
gavinandresen commented at 4:40 PM on May 9, 2011: contributor

Is it true that <amount> is rounded to the nearest 0.01? I don't think AmountFromValue does that any more... While you're fixing that, remove the future-proof-CriticalSection, too, please.
jgarzik commented at 4:47 PM on May 9, 2011: contributor

re AmountFromValue: that was copied from elsewhere in rpc.cpp... sendfrom, maybe? I'd like to be consistent one way or the other :)
gavinandresen commented at 6:27 PM on May 9, 2011: contributor

Fixed sendtoaddress/sendfrom: 8adcf8 / src/rpc.cpp : Help for sendtoaddress/sendfrom was wrong: amounts are rounded to 0.00000001
Add settxfee RPC, to permit setting default TX fee at runtime. d9068ad5a1
jgarzik commented at 6:36 PM on May 9, 2011: contributor

Updated commit per comments.
gavinandresen commented at 6:50 PM on May 9, 2011: contributor

ACK
jgarzik referenced this in commit 04a667b076 on May 9, 2011
jgarzik merged this on May 9, 2011
jgarzik closed this on May 9, 2011
sipa referenced this in commit ecae2acb06 on Dec 11, 2014
dexX7 referenced this in commit 0aeb5559c3 on Jul 29, 2015
TheBlueMatt referenced this in commit 582b2934e6 on Oct 20, 2015
sidhujag referenced this in commit b57198db34 on Mar 4, 2016
ptschip referenced this in commit c262086bb1 on Nov 9, 2016
rebroad referenced this in commit 49b8f42b21 on Dec 7, 2016
deadalnix referenced this in commit bccaf86caa on Jan 19, 2017
lateminer referenced this in commit 8a79b2e247 on Dec 9, 2017
classesjack referenced this in commit e58d7ab7e4 on Jan 2, 2018
cryptapus referenced this in commit 4287b00cf0 on May 2, 2019
attilaaf referenced this in commit 048de51ac8 on Jan 13, 2020
rajarshimaitra referenced this in commit 424196247b on Mar 23, 2021
rajarshimaitra referenced this in commit dae192a37c on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

jgarzik

gavinandresen

mikegogulski

Linked (view graph)

#25323 miniscript fuzzer failing after qa-assets update