[test] Rename rpc_timewait to rpc_timeout #15026

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:Mf1812-testRpcTimeout changing 8 files +21 −10
  1. MarcoFalke commented at 4:35 PM on December 22, 2018: member

    This is a bugfix, since wallet_dump currently uses the wrong name:

    https://github.com/bitcoin/bitcoin/blob/18857b4c4034af54e7ad3cbd78ff6f87f4f22567/test/functional/wallet_dump.py#L89-L92

    Rename all to the same name with a scripted diff (and some unrelated cleanups).

  2. scripted-diff: Remove unused 'split' parameter to setup_network
    -BEGIN VERIFY SCRIPT-
    sed -i -e 's/, split=False//g' $(git grep -l 'def setup_network')
    -END VERIFY SCRIPT-
    fa3e5786d0
  3. scripted-diff: Rename rpc_timewait to rpc_timeout
    -BEGIN VERIFY SCRIPT-
    sed -i -e 's/self.rpc_timewait/self.rpc_timeout/g' $(git grep -l self.rpc_timewait)
    -END VERIFY SCRIPT-
    fa71b38168
  4. whitespace: Split ~300 char line into multiple ones 4999992c34
  5. MarcoFalke added the label Tests on Dec 22, 2018
  6. gkrizek commented at 7:54 PM on December 22, 2018: contributor

    utACK 4999992

  7. DrahtBot commented at 12:50 PM on December 24, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #8994 (Testchains: Introduce custom chain whose constructor... by jtimon)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. promag commented at 5:07 PM on December 26, 2018: member

    utACK 4999992.

  9. MarcoFalke referenced this in commit 2741b2b6f4 on Dec 29, 2018
  10. MarcoFalke merged this on Dec 29, 2018
  11. MarcoFalke closed this on Dec 29, 2018

  12. MarcoFalke deleted the branch on Dec 29, 2018
  13. Munkybooty referenced this in commit d0c25d405d on Aug 8, 2021
  14. Munkybooty referenced this in commit 06c1106753 on Aug 11, 2021
  15. Munkybooty referenced this in commit bd78769492 on Aug 11, 2021
  16. Munkybooty referenced this in commit 943d61c941 on Aug 13, 2021
  17. Munkybooty referenced this in commit 2d5d90735a on Aug 15, 2021
  18. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me