Tests: IsReachable is the inverse of IsLimited (DRY) #15044

pull mmachicao wants to merge 2 commits into bitcoin:master from mmachicao:net_contract_test changing 2 files +306 −314

mmachicao commented at 7:27 PM on December 27, 2018: contributor
IsReachable is the inverse of IsLimited, but the implementation is duplicated (DRY)
- Changed the implementation accordingly.
- Added unittests to document behavior and relationship
- Unittests have to reset values because of internal statefull variables.
- My modification in net.cpp applies only to IsReachable.
- Applied clang -> (unfortunately) lots of changes on formatting
IsReachable is the inverse of IsLimited (DRY) c6aaecfd21
Stateful value have to be resetted d492c263fe
in src/net.cpp:180 in d492c263fe
```
 179 | -void AdvertiseLocal(CNode *pnode)
 180 | +void AdvertiseLocal(CNode* pnode)
 181 |  {
 182 | -    if (fListen && pnode->fSuccessfullyConnected)
 183 | -    {
 184 | +    if (fListen && pnode->fSuccessfullyConnected) {
```
MarcoFalke commented at 7:34 PM on December 27, 2018:

We run https://github.com/bitcoin/bitcoin/tree/master/contrib/devtools#clang-format-diffpy only on the diff and not the whole file.

mmachicao commented at 1:01 AM on December 28, 2018:

Hi MarkoFalke. I am afraid, appveyor will reject a file that is not fully formatted according to clang rules. Better bite the bullet now?

MarcoFalke commented at 11:35 AM on December 28, 2018:

We don't check formatting in appveyor. Do you have a failing build to link to?
fanquake added the label Tests on Dec 27, 2018
DrahtBot commented at 11:56 AM on December 28, 2018: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14929 (net: Allow connections from misbehavior banned peers by gmaxwell)
- #14897 (randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs)
- #14358 ([logs] Fix a few log messages related to duration measurement by romanz)
- #14336 (net: implement poll by pstratem)
- #14033 (p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
mmachicao commented at 3:29 PM on December 28, 2018: contributor

Closing this one. Am providing another pull request with the minimal change set.

Note: Jsut reviewed. The conflicts with other pull requests are related exclusively to the application of clang format. Will create a pull request with clang format exclusively for my changed lines.
mmachicao closed this on Dec 28, 2018
laanwj referenced this in commit 854ca855ab on Jan 9, 2019
PastaPastaPasta referenced this in commit 8cf5230dc1 on Jun 26, 2021
PastaPastaPasta referenced this in commit 8223053a49 on Jun 28, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#15051 Tests: IsReachable is the inverse of IsLimited (DRY). Includes unit tests

Tests: IsReachable is the inverse of IsLimited (DRY) #15044

Conflicts