test: Add basic test for BIP34 #15059

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1812-testBip34 changing 3 files +26 −13

MarcoFalke commented at 6:41 PM on December 29, 2018: member

BIP34 was disabled for testing, which explains why it had no test.

Fix that by enabling it and adding a test.
test: Add basic test for BIP34 fab17e8272
MarcoFalke added the label Tests on Dec 29, 2018

DrahtBot commented at 7:54 PM on December 29, 2018: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Coverage	Change (pull 15059, 1d880e789c555b6653b3984f87ae052a816831c4)	Reference (master, 96d912bea82ae0960a193c93ece4739a4e0856e2)
Lines	+0.0000 %	87.3369 %
Functions	+0.0151 %	84.4498 %
Branches	+0.0105 %	51.3677 %

<sup>Updated at: 2018-12-29T19:54:43.800451.</sup>

laanwj commented at 1:24 PM on January 2, 2019: member

utACK fab17e8272f5f70213f186809479ee7a75898b1d
laanwj merged this on Jan 8, 2019
laanwj closed this on Jan 8, 2019
laanwj referenced this in commit c6806ee869 on Jan 8, 2019
jnewbery commented at 3:39 PM on January 9, 2019: member

tested ACK fab17e8272f5f70213f186809479ee7a75898b1d.

It might be a good idea to update the default block version number to >=2 (or better, >=4) here:

https://github.com/bitcoin/bitcoin/blob/699d0bd9fe5d39dd078ae4996079af2caf29a4e3/test/functional/test_framework/messages.py#L543

Building a chain that exceeds 500 blocks and having it rejected for 'bad-version(0x00000001)' is probably going to trip some people up.
MarcoFalke deleted the branch on Jan 9, 2019
deadalnix referenced this in commit e54a99e4eb on Jun 23, 2020
vijaydasmp referenced this in commit ca7f9e43bf on Oct 23, 2021
vijaydasmp referenced this in commit c1446bccf7 on Oct 23, 2021
vijaydasmp referenced this in commit 9b1c1758b4 on Oct 23, 2021
vijaydasmp referenced this in commit d757255c34 on Oct 26, 2021
vijaydasmp referenced this in commit e761f728c3 on Oct 26, 2021
vijaydasmp referenced this in commit 782a2fee27 on Oct 26, 2021
vijaydasmp referenced this in commit 8e1c294a3e on Oct 29, 2021
vijaydasmp referenced this in commit f6c6561abb on Oct 30, 2021
vijaydasmp referenced this in commit 28b7695568 on Nov 2, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels