Changed a comment about a QVariant type #1508

pull xanatos wants to merge 1 commits into bitcoin:master from xanatos:patch-5 changing 1 files +1 −1

xanatos commented at 2:30 PM on June 23, 2012: none

The OptionsModel::data that set it has changed. Now it's

        case ProxyPort: {
            CService addrProxy;
            if (GetProxy(NET_IPV4, addrProxy))
                return QVariant(addrProxy.GetPort());
            else
                return 9050;
        }

GetPort() returns an unsigned short, that is upcasted by the QVariant (that doesn't directly support shorts)

Changed a comment about a QVariant type 3948eb0c54
Diapolo commented at 4:26 PM on June 23, 2012: none

Is the type-casting to int instead of short a problem here? I'm asking because I'm working on the proxy-options in the GUI currently.

ACK to the pull.
gavinandresen merged this on Jun 28, 2012
gavinandresen closed this on Jun 28, 2012
suprnurd referenced this in commit b39c518d5a on Dec 5, 2017
lateminer referenced this in commit 705d745c6d on Jan 22, 2019
lateminer referenced this in commit 104db7d7f3 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

xanatos

Diapolo