Language selector should use language names instead of codes #1509
issue luke-jr opened this issue on June 23, 2012-
luke-jr commented at 5:46 PM on June 23, 2012: member
-
laanwj commented at 2:10 PM on June 25, 2012: member
Use
QLocale::countryToString/QLocale::languageToString(http://doc.qt.nokia.com/4.7-snapshot/qlocale.html#languageToString), it returns the full name for a country / language. -
Diapolo commented at 6:07 PM on June 25, 2012: none
Tried it and should be rather easy to do ... perhaps I'll create a patch later.
-
Diapolo commented at 11:04 AM on June 27, 2012: none
Can be closed now!
-
luke-jr commented at 4:33 PM on June 27, 2012: member
IMO, this should be using nativeLanguageName
-
Diapolo commented at 4:48 PM on June 27, 2012: none
Nice idea, but
This function was introduced in Qt 4.8.and we are still compiling using an older 4.7.4 (4.8.2 is current).Edit: We could aswell use
nativeCountryName()then, which would be even better.Edit 2: That's how it would look then:
-
-
laanwj commented at 2:11 PM on July 12, 2012: member
We won't require a higher Qt version for the forseeable future, however you can use 4.8 features in a
#if QT_VERSION >= 0x040800guard so that people that do compile with 4.8 get the better functionality. -
Diapolo commented at 2:20 PM on July 12, 2012: none
Good point, I'll consider this, but it would get pretty ugly, when there are many places in the code with such guards.
-
laanwj commented at 2:25 PM on July 12, 2012: member
I wouldn't consider that much of a problem in this case. It's simply how backward compatible programming works. It's much worse in web development, at least you don't have to support IE 6 :-)
-
Diapolo commented at 2:30 PM on July 12, 2012: none
AFAIK we support / require IE 5.01 :-P!?
#define _WIN32_IE 0x0501 -
- laanwj closed this on Jul 17, 2012
- lateminer referenced this in commit c891c1478f on Jan 22, 2019
- lateminer referenced this in commit 13c4302087 on May 6, 2020
- MarcoFalke locked this on Sep 8, 2021
