Add comment describing fDisconnect behavior #15194

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-01-add-fDisconnect-comment changing 1 files +2 −0

dongcarl commented at 11:29 PM on January 17, 2019: member

Motivated by @Sjors here: #14605 (review)
Add comment describing fDisconnect behavior 5b4283cb81
fanquake added the label Docs on Jan 17, 2019
fanquake added the label P2P on Jan 17, 2019
Sjors commented at 9:55 AM on January 18, 2019: member

Concept ACK, assuming it's correct :-)
sdaftuar commented at 3:33 PM on January 18, 2019: member

utACK
laanwj commented at 3:11 PM on January 20, 2019: member

utACK 5b4283cb81b5d3023b9868d121b22b1f387a50ca
laanwj merged this on Jan 20, 2019
laanwj closed this on Jan 20, 2019
laanwj referenced this in commit 978682b9dc on Jan 20, 2019

in src/net.h:693 in 5b4283cb81

 688 | @@ -689,6 +689,8 @@ class CNode
 689 |      bool m_limited_node{false}; //after BIP159, set by version message
 690 |      const bool fInbound;
 691 |      std::atomic_bool fSuccessfullyConnected{false};
 692 | +    // Setting fDisconnect to true will cause the node to be disconnected the
 693 | +    // next time DisconnectNodes() runs

MarcoFalke commented at 3:18 AM on January 25, 2019:

nit: would be nice to use doxygen compatible comments (see developer notes and https://dev.visucore.com/bitcoin/doxygen/class_c_node.html#adebd9bb3224ed2c5ab63fdfd9c6e9074)

Munkybooty referenced this in commit 8edd40fcff on Aug 21, 2021
Munkybooty referenced this in commit 27c483e6fd on Aug 23, 2021
Munkybooty referenced this in commit aceea13f9f on Aug 24, 2021
Munkybooty referenced this in commit 9845e85bcd on Aug 24, 2021
Munkybooty referenced this in commit 53a6f62ea4 on Aug 24, 2021
UdjinM6 referenced this in commit 45c54cb89d on Aug 24, 2021
Munkybooty referenced this in commit 30f6319fd0 on Aug 24, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#14605 Return of the Banman