Wallet: Remove "-Wunused-variable" warning while build with "--disable-wallet" option #15217

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190120-unused-variable-warning changing 1 files +1 −4

hebasto commented at 6:53 PM on January 20, 2019: member

Currently in master:

$ make distclean
$ ./configure --disable-wallet
$ make >> /dev/null
...
qt/rpcconsole.cpp: In member function ‘void RPCConsole::on_lineEdit_returnPressed()’:
qt/rpcconsole.cpp:907:22: warning: unused variable ‘wallet_model’ [-Wunused-variable]
         WalletModel* wallet_model{nullptr};
                      ^~~~~~~~~~~~

This refactoring PR does not change the behavior of code.

cc @promag

Remove -Wunused-variable while --disable-wallet dda7cb7163
promag commented at 7:07 PM on January 20, 2019: member

There is already a fix in #15150 b669ba6bd86a7808e4692bb0cf692b1c95d8d32d.
hebasto commented at 7:12 PM on January 20, 2019: member

@promag you are right.
hebasto closed this on Jan 20, 2019
Sjors commented at 1:26 PM on January 16, 2020: member

Unfortunately that never got merged.
hebasto deleted the branch on Jan 18, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

hebasto

promag

Sjors