git HEAD crashes on shutdown #1524

issue jgarzik opened this issue on June 27, 2012

jgarzik commented at 6:00 PM on June 27, 2012: contributor

Platform: Fedora 16, x86-64, non-GUI (bitcoind) build

Within the last ~48 hours, git HEAD started crashing on shutdown:

 06/27/12 17:54:16 Added 1 addresses from 174.56.21.146: 288 tried, 11796 new
 06/27/12 17:54:16 CTxMemPool::accept() : accepted 3b0b194bea (poolsz 15)
 06/27/12 17:54:18 connection timeout
 06/27/12 17:54:18 ThreadRPCServer method=stop
 06/27/12 17:54:18 ThreadRPCServer exited
 06/27/12 17:54:18 Flush(false)
 06/27/12 17:54:18    [log stops here; bitcoind has exited]

gavinandresen commented at 6:04 PM on June 27, 2012: contributor

Likely suspect: #457 (comment)
jgarzik commented at 5:02 AM on June 28, 2012: contributor
git bisect says the following commit is to blame:

fbf9df2ea32528c71b58160283b4eb2c52e30ccb is the first bad commit commit fbf9df2ea32528c71b58160283b4eb2c52e30ccb Author: Giel van Schijndel me@mortis.eu Date: Sun May 20 20:27:53 2012 +0200
```
Use the QueueShutdown signal to stop accepting new RPC connections

Signed-off-by: Giel van Schijndel <me@mortis.eu>
```
:040000 040000 544ed979f0a63774de57d1629aa81160a2fd7e87 4564e50df12650d581723f80801c2e3965a40261 M src
jgarzik commented at 12:14 AM on June 29, 2012: contributor

Fixed, as of 5fa83965f22ae92f86de74104b621c2168d37698
jgarzik closed this on Jun 29, 2012
suprnurd referenced this in commit eea78d45ed on Dec 5, 2017
lateminer referenced this in commit 6e1745be85 on May 6, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

jgarzik

gavinandresen