Incorrect or duplicate assertion in key.cpp signing code #15286

issue maaku opened this issue on January 29, 2019

maaku commented at 7:49 PM on January 29, 2019: contributor

The following assertion seems redundant. Is it a mistake? Two lines prior the same assertion is made, and the value being asserted doesn't appear to change in-between. However the next line asserts a condition on a different variable which differs by only one letter. Is the referenced line a duplicate assertion of ret and therefore redundant, or is it supposed to be assert(rec)?

https://github.com/bitcoin/bitcoin/blob/7275365c9bc7e7ebd6bbf7dcb251946aac44b5de/src/key.cpp#L247-L251
sipa commented at 8:29 PM on January 29, 2019: member

Thanks for pointing this out. It looks like the line is redundant indeed. rec can take any value from 0 to 3 inclusive, so assert(rec) would be wrong.
promag commented at 3:03 PM on January 31, 2019: member

I think ret must be updated in L249. If that's the case a fix is in #15299.
laanwj closed this on Jan 31, 2019
laanwj referenced this in commit 4b6673d382 on Jan 31, 2019
PastaPastaPasta referenced this in commit 15840af8b7 on Jun 27, 2021
PastaPastaPasta referenced this in commit 924794db7a on Jun 28, 2021
PastaPastaPasta referenced this in commit 5d1d202bc0 on Jun 28, 2021
PastaPastaPasta referenced this in commit 8846f79220 on Jun 29, 2021
DrahtBot locked this on Dec 16, 2021

Contributors