[build] Makefile.am: add rule for src/bitcoin-wallet #15388

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/02/wallet_tool_make changing 2 files +6 −0
  1. Sjors commented at 4:03 PM on February 12, 2019: member

    Otherwise make src/bitcoin-wallet will fail with No rule to make target.

    Also adds bitcoin-wallet.exe to the Windows installer.

  2. MarcoFalke added the label Build system on Feb 12, 2019
  3. Sjors commented at 4:04 PM on February 12, 2019: member

    I just duplicated everything to make it consistent with make src/bitcoin-tx. @jnewbery: I think this was missing from #13926 @ken2812221 does the Windows installer bit look OK? @MarcoFalke this probably needs a Gitian build.

    Thanks @luke-jr & @laanwj for IRC help.

  4. MarcoFalke added the label Needs gitian build on Feb 12, 2019
  6. jnewbery commented at 5:35 PM on February 12, 2019: member

    utACK c9741df229652ff1ea2a14d705a8fac727d6cd55. Thanks @Sjors!

  7. promag commented at 5:44 PM on February 12, 2019: member

    Tested ACK c9741df on macOS.

  8. in Makefile.am:80 in c9741df229 outdated 
      76 | @@ -76,6 +77,7 @@ $(BITCOIN_WIN_INSTALLER): all-recursive
  77 |  	STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_QT_BIN) $(top_builddir)/release
  78 |  	STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_CLI_BIN) $(top_builddir)/release
  79 |  	STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_TX_BIN) $(top_builddir)/release
  80 | +	STRIPPROG="$(STRIP)" $(INSTALL_STRIP_PROGRAM) $(BITCOIN_WALLET_BIN) $(top_builddir)/release
    luke-jr commented at 6:39 PM on February 12, 2019:

    You also need to add it to share/setup.nsi.in

  9. in Makefile.am:91 in c9741df229 outdated 
      87 | @@ -86,7 +88,7 @@ $(OSX_APP)/Contents/PkgInfo:
  88 |  
  89 |  $(OSX_APP)/Contents/Resources/empty.lproj:
  90 |  	$(MKDIR_P) $(@D)
  91 | -	@touch $@ 
  92 | +	@touch $@
    luke-jr commented at 6:39 PM on February 12, 2019:

    Why the unrelated whitespace changes?

    Sjors commented at 6:44 PM on February 12, 2019:

    My editor is set to pedantic mode. Not sure why we missed this in #13753.

  10. in Makefile.am:303 in c9741df229 outdated 
     304 | @@ -300,4 +305,3 @@ clean-docs:
 305 |  clean-local: clean-docs
 306 |  	rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
 307 |  	rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__
 308 | -
    luke-jr commented at 6:40 PM on February 12, 2019:

    More whitespace

  11. luke-jr changes_requested
  12. DrahtBot removed the label Needs gitian build on Feb 13, 2019
  13. MarcoFalke added the label Needs gitian build on Feb 13, 2019
  14. Sjors force-pushed on Feb 13, 2019
  15. Sjors commented at 3:06 PM on February 13, 2019: member

    Also added to share/setup.nsi.in.

  16. MarcoFalke deleted a comment on Feb 13, 2019
  17. Sjors force-pushed on Feb 14, 2019
  18. Sjors commented at 9:02 AM on February 14, 2019: member

    I added 7640765 to see if busting AppVeyor cache (again) can help with breaking builds in master. It's otherwise unrelated to this PR so I can drop the commit or move it to another PR later if needed.

  19. Sjors force-pushed on Feb 14, 2019
  20. Sjors force-pushed on Feb 14, 2019
  21. Sjors commented at 10:39 AM on February 14, 2019: member

    I moved the AppVeyor commits to a new PR #15405. See also #15407 for a likely solution to the AppVeyor failures.

  22. [build] Makefile.am: add rule for src/bitcoin-wallet 4a43eb8cdf
  23. Sjors force-pushed on Feb 14, 2019
  24. luke-jr approved
  25. luke-jr commented at 3:24 PM on February 14, 2019: member

    utACK

  26. MarcoFalke merged this on Feb 14, 2019
  27. MarcoFalke closed this on Feb 14, 2019
  28. MarcoFalke referenced this in commit 9b1df4ba0b on Feb 14, 2019
  29. Sjors deleted the branch on Feb 14, 2019
  30. DrahtBot commented at 5:13 PM on February 14, 2019: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 0d1160e42185983b398cbc2e2be379002f4a62e9 (master):

    Gitian builds for commit a88d457155881cda117dbf84bd73c05f6bbdf804 (master and this pull):

  31. DrahtBot removed the label Needs gitian build on Feb 14, 2019
  32. PastaPastaPasta referenced this in commit f32276de06 on Jun 27, 2021
  33. PastaPastaPasta referenced this in commit 95c7e18b38 on Jun 28, 2021
  34. PastaPastaPasta referenced this in commit 6c303bd52d on Jun 29, 2021
  35. PastaPastaPasta referenced this in commit 3f782d1d85 on Jul 1, 2021
  36. PastaPastaPasta referenced this in commit 0474e4e88d on Jul 1, 2021
  37. PastaPastaPasta referenced this in commit 09633ea759 on Sep 11, 2021
  38. MarcoFalke locked this on Dec 16, 2021
Contributors
Sjorslaanwjjnewberypromagluke-jrDrahtBot
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 09:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me