test: Remove TODO comments to remove -txindex option #15395

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1902-qaNoTodo changing 7 files +48 −52

MarcoFalke commented at 11:15 PM on February 12, 2019: member

No description provided.
test: fix whitespace in rpc_psbt.py fa9fe0eec8
test: Remove TODO comment to remove -txindex option fa15244fd0
fanquake added the label Tests on Feb 12, 2019
jnewbery commented at 12:05 AM on February 13, 2019: member

I think @amitiuttarwar is already working on removing these as a follow-up to #15159.
MarcoFalke commented at 12:47 AM on February 13, 2019: member

I wanted to get this in to 0.18.0 without a backport and I haven't seen a follow-up in the last two weeks. Though, happy to close my pull if someone want to take this over.
amitiuttarwar commented at 1:10 AM on February 13, 2019: contributor

I've been working on it & was close to putting up a PR, but its ok :) My changes are pretty similar. I can contribute an additional change to the interface_rest test to remove -txindex by updating to search for a mempool transaction.
MarcoFalke commented at 1:33 AM on February 13, 2019: member

Please open you pull request with the changes. I am happy to provide feedback on those.
DrahtBot commented at 1:40 AM on February 13, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14978 (Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen)
- #14053 (Add address-based index (attempt 4?) by marcinja)
- #13932 (Additional utility RPCs for PSBT by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke closed this on Feb 13, 2019
MarcoFalke deleted the branch on Feb 13, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

test: Remove TODO comments to remove -txindex option #15395

Conflicts