AppVeyor builds started starting failing on master after I cleaned the cache in #15382. In addition, it appeared that a new dependency (boost-process) wasn't getting added in that PR without at least cleaning the vcpkg cache.
[build] AppVeyor: clean cache when build configuration changes #15405
pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/02/appveyor_cache changing 1 files +2 −2-
Sjors commented at 10:16 AM on February 14, 2019: member
-
Sjors commented at 10:16 AM on February 14, 2019: member
In general it seems unhealthy that independent PRs can mess with AppVeyor cache. Not sure how Travis handles that; maybe cache can be made read-only for PR's and only allow master to write to it?
cc @ken2812221
- fanquake added the label Tests on Feb 14, 2019
-
ken2812221 commented at 12:13 PM on February 14, 2019: contributor
-
Sjors commented at 12:22 PM on February 14, 2019: member
@ken2812221 thanks! Let's see if your PR makes the error go away.
Do you think the cache rules in this PR make sense?
-
DrahtBot commented at 12:23 PM on February 14, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- MarcoFalke closed this on Feb 14, 2019
- MarcoFalke reopened this on Feb 14, 2019
-
[build] AppVeyor: clean cache when build configuration changes 88a91e2c9d
- Sjors force-pushed on Feb 14, 2019
-
ken2812221 commented at 9:30 AM on February 15, 2019: contributor
utACK 88a91e2c9d9ec1bee54d2676a74040e3f7665a2d
- MarcoFalke merged this on Feb 15, 2019
- MarcoFalke closed this on Feb 15, 2019
- MarcoFalke referenced this in commit bf3677a6bb on Feb 15, 2019
- Sjors deleted the branch on Feb 15, 2019
- linuxsh2 referenced this in commit 15e3ccfe5b on Sep 16, 2021
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels