tests: remove byte.hex() to keep compatibility #15439

1. 
   AkioNak commented at 8:49 am on February 19, 2019: contributor

   Use test_framework.util.bytes_to_hex_str() instead of bytes.hex() that new in Python 3.5 to support minimum version of Python(test).

   test/functional/test_framework/wallet_util.py is also reported to have ‘.hex()’ in #15397, but it does not matter because it calls CScript.hex() defined in wallet_util.py.

2. tests: remove byte.hex() to keep compatibility

   Use test_framework.util.bytes_to_hex_str() instead of bytes.hex() that
   new in Python 3.5, to support minimum version of Python(test).

   1a062b85f0
3. fanquake added the label Tests on Feb 19, 2019
4. fanquake requested review from MarcoFalke on Feb 19, 2019
5. MarcoFalke added this to the milestone 0.18.0 on Feb 19, 2019
6. 
   MarcoFalke commented at 1:51 pm on February 19, 2019: member

   Let’s merge this after the branch off to 0.18
7. 
   laanwj commented at 2:12 pm on February 19, 2019: member

   Let’s merge this after the branch off to 0.18

   To be clear: you want to merge this to the 0.18 branch after there is a 0.18 branch?

8. 
   MarcoFalke commented at 3:06 pm on February 19, 2019: member

   Yes, there is no reason to have this in the 0.19 brach
9. 
   laanwj commented at 3:35 pm on February 19, 2019: member

   OK makes sense—let’s ask @AkioNak to change the target branch when it’s there
10. 
    Sjors commented at 9:24 am on February 20, 2019: member

    tACK 1a062b8. I’m OK with merging it into the 0.18 branch. Although it took me some time to find this after running into these test failures myself.
11. 
    MarcoFalke commented at 2:18 pm on February 20, 2019: member

    Ok, it appears at least two devs are using pyenv and would be unable to run the tests at all for the next two weeks. Going to merge this now and then revert in #14954
12. MarcoFalke referenced this in commit f9775a8655 on Feb 20, 2019
13. MarcoFalke merged this on Feb 20, 2019
14. MarcoFalke closed this on Feb 20, 2019

    ---

15. AkioNak deleted the branch on Feb 24, 2019
16. Munkybooty referenced this in commit 4e0492847d on Sep 7, 2021
17. Munkybooty referenced this in commit ed5543e6bf on Sep 7, 2021
18. Munkybooty referenced this in commit bc7ca5d837 on Sep 7, 2021
19. Munkybooty referenced this in commit b654e48dbc on Sep 7, 2021
20. DrahtBot locked this on Dec 16, 2021

Contributors
AkioNak MarcoFalke laanwj Sjors

Review Requested
MarcoFalke

Labels
Tests

Milestone
0.18.0