GETDATA is limited to blocks and transactions now and can't be used for other non-block data
[doc] clarify getdata limit after #14897 #15451
pull HashUnlimited wants to merge 1 commits into bitcoin:master from HashUnlimited:patch-2 changing 1 files +1 −1-
HashUnlimited commented at 8:01 PM on February 20, 2019: contributor
-
c119ba3c9b
[doc] clarify getdata limit after #14897
GETDATA is limited to blocks and transactions now and can't be used for other non-block data
-
MarcoFalke commented at 9:27 PM on February 20, 2019: member
How is #14897 related to this change at all?
- fanquake added the label Docs on Feb 21, 2019
- fanquake added the label P2P on Feb 21, 2019
-
HashUnlimited commented at 6:15 AM on February 21, 2019: contributor
before:
const CInv& inv = (*pto->mapAskFor.begin()).second;has handled basically every type of inventory left in the map. So the "non-blocks" description was accurate. The PR is explicitly creatingCInv inv(MSG_TX | GetFetchFlags(pto), txid);instead, so the old description may be misleading, assuming that this door has been closed intentionally. -
laanwj commented at 10:07 AM on October 2, 2019: member
I think this clarification is fine, the only things exchanged through this mechanism are blocks and transactions anyway.
ACK c119ba3c9b321a7f4418860741b3f69173e9c891
- theStack approved
-
theStack commented at 1:55 PM on February 7, 2020: member
- DrahtBot closed this on Mar 9, 2020
-
DrahtBot commented at 8:34 PM on March 9, 2020: member
<!--5d09a71f8925f3f132321140b44b946d-->The last travis run for this pull request was 383 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.
- DrahtBot reopened this on Mar 9, 2020
-
adamjonas commented at 1:33 PM on August 10, 2020: member
Bumping this as this one-line doc change has two ACKs (theStack and laanwj) and while about 18 months old, doesn't appear to require a rebase.
- benthecarman approved
-
benthecarman commented at 8:35 AM on December 25, 2020: contributor
ACK c119ba3c9b321a7f4418860741b3f69173e9c891
- MarcoFalke merged this on Dec 25, 2020
- MarcoFalke closed this on Dec 25, 2020
- sidhujag referenced this in commit 68c18bc1da on Dec 25, 2020
- PastaPastaPasta referenced this in commit ca2a430574 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 23776b4c53 on Jun 28, 2021
- PastaPastaPasta referenced this in commit fb5de1fdc9 on Jun 29, 2021
- PastaPastaPasta referenced this in commit 4a516525d2 on Jul 1, 2021
- PastaPastaPasta referenced this in commit a00d0c25d7 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 4028ce8e8b on Jul 15, 2021
- PastaPastaPasta referenced this in commit 4bb9abf422 on Jul 15, 2021
- PastaPastaPasta referenced this in commit 1177bc94fc on Sep 17, 2021
- DrahtBot locked this on Feb 15, 2022
