0.17 #15475

pull geekastute wants to merge 149 commits into bitcoin:master from bitcoin:0.17 changing 169 files +2238 −1080

geekastute commented at 5:47 PM on February 25, 2019: none
Pull requests without a rationale and clear improvement may be closed immediately.

Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly.
- Any test improvements or new tests that improve coverage are always welcome.
- All other changes should have accompanying unit tests (see src/test/) or functional tests (see test/). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change.
- Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed.
- Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible.
- Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they significantly improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the developer notes, stylistic code changes are usually rejected.
Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time.

build: bump version to 0.17.0

Update version after branching off.

Tree-SHA512: a2e2f82e7b50c0027edc8f382ad29429327edb81ca058abe3c35e049afcd5b7bcedae4545bfb59e8f7a1c8b9c97cfe550d8ae9275bd9e90cfadea22f7b835a2b

cd2f4f35bb

doc: regenerate manpages f0f745d8de

Merge #13956: [0.17] doc: regenerate manpages

f0f745d8de9ab8fd18208671294063abf783cf90 doc: regenerate manpages (fanquake)

Pull request description:

  Done using: `contrib/devtools/gen-manpages.sh`

Tree-SHA512: 523b333768aa5ff289ceee3dbe627698f60c7b4624a1fe2812a40d99a5184aa2f6abd20fa467487918bbcbe1d88693c589456e75a5e747281333f75ab1f5f8b9

ff41e479a0

Fix PSBT deserialization of 0-input transactions

0-input transactions can be ambiguously deserialized as being witness
transactions. Since the unsigned transaction is never serialized as
a witness transaction as it has no witnesses, we should always
deserialize it as a non-witness transaction and set the serialization
flags as such.

Also always serialize the unsigned transaction as a non-witness transaction.

GitHub-Pull: #13960
Rebased-From: 43811e6

8c4cd2bd89

Serialize non-witness utxo as a non-witness tx but always deserialize as witness

Strip out the witnesses when serializing the non-witness utxo. However
witness serializations are allowed, so make sure we always deserialize
as witness.

GitHub-Pull: #13960
Rebased-From: bd19cc7

517010e30e

Additional sanity checks in SignPSBTInput
GitHub-Pull: #13917 Rebased-From: 8254e99
ad6d845ac9
Only wipe wrong UTXO type data if overwritten by wallet
GitHub-Pull: #13917 Rebased-From: c05712c
dbaadc9ea9
Test that a non-witness script as witness utxo is not signed
GitHub-Pull: #13917 Rebased-From: 7c8bffd
8935869487

More tests of signer checks

GitHub-Pull: #13917
Rebased-From: 5df6f08

0333914467

Merge #13976: [0.17] Backport #13960 & #13917

0333914467466d22133e25b71ef330bb2c609958 More tests of signer checks (Andrew Chow)
8935869487ffe858534d73c4929a4ee3d96ca6ac Test that a non-witness script as witness utxo is not signed (Andrew Chow)
dbaadc9ea92fd0e221c60584a5d1ca871fdd9c66 Only wipe wrong UTXO type data if overwritten by wallet (Pieter Wuille)
ad6d845ac9d43aac663fa46912b49aaf837a1a9e Additional sanity checks in SignPSBTInput (Pieter Wuille)
517010e30e4ac52868fcfd537b644515f3081f88 Serialize non-witness utxo as a non-witness tx but always deserialize as witness (Andrew Chow)
8c4cd2bd895fe7467307867fefc3cd45a685367c Fix PSBT deserialization of 0-input transactions (Andrew Chow)

Pull request description:

  Backports #13917 and #13960 to the 0.17 branch.

Tree-SHA512: b3853aff2a13a53aa0a390b6b4b0c539f0ef0d42f2c517e956efd0b135c74c4ddce6a1d00700849a58c696824fa95951d8cac6ca58b426e8dfcb8bb62f680b7c

4a2960f73e

qt: Pre-rc1 translations update

Tree-SHA512: 11d0d6a23f47e428661b33fa175aa97cc6841452c0c55845fdb0a903a0b147cd6df65e8fdab8b98823bf411018d5d85006af8c2cf14597286e9e284764d15041

3d827bee69

depends: fix qt determinism

Qt's configure grabs the path to xkb's data root during configure, but the
build changes in 5.8 apparently broke the handling for cross builds. As a
result, the string embedded in the binary depends on whether or not some files
are present in the builder's filesystem.

The "-xkb-config-root" configure setting is intended to allow manual overriding
but it is also broken. See: https://bugreports.qt.io/browse/QTBUG-60005

This has since been fixed upstream, so just hard-code the path for now. We can
drop this patch when we bump to a fixed Qt.

Also, fix the "-qt-xkbcommon-x11" config param which was renamed. This does not
appear to affect build results, presumably because auto-detection is working,
but it does not hurt to be explicit.

Github-Pull: #14000
Rebased-From: de0b4fba2fb5270dcc8d851243af9187b8ef191a

48c845902a

Merge #14005: [0.17] depends: fix qt determinism

48c845902ac044af99ceb7cacc1ea3eacfaeb913 depends: fix qt determinism (Cory Fields)

Pull request description:

  Backport for rc2

Tree-SHA512: 990a1b32ca8c80b22595c4b19e801d5033e42b7e86da0f80028e708131a136f6383d7510dab8bd7cd12fe8533f73246fe78c72a8a22a54eb136b2bfada1e67ea

1ffd67f11f

Allow ConstructTransaction to not throw error with 0-input txn

Github-Pull: #13968
Rebased-From: 2252ec50085c151e7998ca9a30cda6a33ee862b6
Tree-SHA512: 1f9978ee25fbe9bb338af19d81b401fa531d314ac8288cdb21c1bf10459edea50b43e2d5e97c9bb5fe24c8db89363f8233c0a3d96066ed85f7bd6d2eb234aac0

c6d905746b

walletcreatefundedpsbt: remove duplicate replaceable arg

Github-Pull: #13968
Rebased-From: 1f18d7b591ffcc8bb9422a9b728bd9a0d8da6a2a
Tree-SHA512: 90391703181db6880a135c60aca792a9e92c4abcad26907cd6cb0a0378593fe45cf995a22ae142ea7de2767c72a9df444e918ff15e460ce19c0435163917d812

65e7a8b97f

QA: add basic walletcreatefunded optional arg test

Github-Pull: #13968
Rebased-From: 1f0c4282e961baea85d5f74d7493bd7459784391
Tree-SHA512: 1f8b10629a314f623d589801ef2e62724de2cd82a0e523e0ab25a285f92b76a3b31304c1c0418b1b611ec3ca0016016d1e6af410ac81a78449b875c4f89a46d7

82e2b9cb25

RPCTypeCheck bip32derivs arg in walletcreatefunded

Github-Pull: #13968
Rebased-From: faaac5caaab4d5131040292f4ef2404074ad268b
Tree-SHA512: 758c0c3e4435897d1a9b03ea93f1b2a1a1b64071eda9450f968acf537c172ee61acf9d962bc22ddb6de26e0ad39d9165cdee6f260bb5a95bf97b4003853f0874

9833545d18

Bugfix: NSIS: Exclude Makefile* from docs

Otherwise, the generated Makefile is included in the NSIS-installed documentation, which can lead to non-determinism (eg, if gawk is installed on some build VMs, but others only have mawk)

Github-Pull: #14018
Rebased-From: 8563341714a1ec452dd3304a39dd880face49c84
Tree-SHA512: 2d219a4a2027bcd7359b7320bafc6b7cd3bde3dcf9309ddd6198ff67407470025baa71e6d0ed3d6cec081834ddc9a0247043865eb26737e6fd0d2f09574f5932

3e4829af09

Docs: Fix help message typo optiona -> optional

Github-Pull: #14056
Rebased-From: 7d0a8ad3103200145ab2e73368c3b8345a66c15d

b5ec6d4bf8

qa: Stop txindex thread before calling destructor

Github-Pull: #14071
Rebased-From: faf4a9b674186923f8c837e3621d147f504c1944

fab0fbefcf

Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe
Github-Pull: #14069 Rebased-From: 737670c036e802e0fd8b51efffb41131d08f0204
cf3d7f94c2

Merge #14084: [0.17] qa: Backports

cf3d7f94c2efd15a9cb910ccee31505934d55641 Use assert when running from multithreaded code as BOOST_CHECK_* are not thread safe (Jesse Cohen)
fab0fbefcf51f38aa858423017b545df6d098311 qa: Stop txindex thread before calling destructor (MarcoFalke)
b5ec6d4bf8a8ca18ca520e2f484e3ddd2d1138a3 Docs: Fix help message typo optiona -> optional (Ben Woosley)

Pull request description:

  Fixes to make the unit tests and bench pass with the thread sanitizer (beside the issue with fChecked https://github.com/bitcoin/bitcoin/issues/14058#issuecomment-416042917).

  For testing: `./configure --with-sanitizers=undefined,thread && make -j 16 && ./src/test/test_bitcoin`

Tree-SHA512: 5cb85ecc278b719dba03240265e93424ed1a28671834da7590adab88c2d43c6e6cbf3269bbe2fd79e5ed3a85ec77a268e05301e7a7421cf6a97d413dddac6327

5f71eac634

fix walletcreatefundedpsbt deriv paths, add test

Github-Pull: #14055
Rebased-From: 61fe653bd919cb0533b2b9d6259bc86a4b2975c0
Tree-SHA512: 2f3edf62318fab4b405b47788096005f59cbe6ba4723fe51ce3b386539a58b7ea7369c31c3840c6baa76cdf6ba8f8440f977c36e2ee2916e711d7872bd1eadad

2307a6eb2b

doc: Change documentation for =0 for non-boolean options

PR #12713 changed the interpretation for negation of non-boolean options
(e.g. -noconnect) to no longer set the option to 0, but to remove it
from the options.

I think this is better because it gets rid of the special meaning of
'0'.

However it needs to be documented. I attempt to do so in this PR.
Addreses #14064.

Github-Pull: #14100
Rebased-From: e9a78e9b3b17e09f923f09c5aae0eda9dfd58e66

2936dbc557

doc: Update v0.17.0.0 manpages 6bfee8a8c2

Merge #14152: [0.17] doc: Change documentation for =0 for non-boolean options

6bfee8a8c2ad0c77d47bedc282a7838aab137508 doc: Update v0.17.0.0 manpages (MarcoFalke)
2936dbc557084be1b0cc16d73250a9f220871062 doc: Change documentation for =0 for non-boolean options (Wladimir J. van der Laan)

Pull request description:

  Github-Pull: #14100
  Rebased-From: e9a78e9b3b17e09f923f09c5aae0eda9dfd58e66

  Includes the bumped manpages.

Tree-SHA512: 73d2dadb45418882122313975c0ab0e9f58310697d996dd2edeb400ebe73b3a45f1157c8a7fe65ae1f53d9ce68a88aae7c701f3e82e0b4db4c9417b36ddfecc0

6ba1f15432

util: Report parse errors in configuration file

Report errors while parsing the configuration file, instead of silently
ignoring them.

    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: nodebuglogfile, if you intended to specify a negated option, use nodebuglogfile=1 instead
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: sdafsdfafs
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 24: -nodebuglogfile=1, options in the configuration file must be specified without leading -

Github-Pull: #14105
Rebased-From: a66c0f78a941968340f030911765a84219908c4d
Tree-SHA512: 2b6be1ab643623e6ef9b53354820147a6c5d2baae3795ffe428fc60d8563ec00a68a379aee4029380f80f892abe23763afb1c75c32b60a13bffe7b82496bf2bb

83aafd5b32

test: Add test for config file parsing errors

Github-Pull: #14105
Rebased-From: ed2332aeffb071a3404be9cff8f9fb8a81a9fbfb
Tree-SHA512: 17fa88a2848f1c9c9c8a127b5ea4c45761ce8e06a609dd40f8e90bb9117d88c9d2c81e752c9c0f1a44ecadbb5bedd2973bc4548da2a6d463c789797191e85ab1

eb202ea21d

Add descriptor reference documentation

Github-Pull: #14096
Rebased-From: 9254ffcf2d910ecb0f9ecbeef6d40a2008a44870
Tree-SHA512: 1fc466177dbe3b57b0025c102b1e75e4b05544440819885da7a85b70d20329fc3f6f4cbf89d7d6a48881e6ad176d81f7396f02925586140e19468a2f28f3414e

0f681cecad

Adjust TODO link

Github-Pull: #14096
Rebased-From: 89709db7a2710456011eac9dcd6a60d5e87b97ae
Tree-SHA512: 0bf74e1179bee6e616d8fd2c125411ef30611d9aa3b32412025615a793abbc629a7b6d89a89ef05b11ac3541cc869c0caebba2d00942fdd6ab8d2e98d9b9caca

eece974d0a

Replace duplcate reference with reference to reference doc

Github-Pull: #14096
Rebased-From: 2b5d6f8df24b381d35b75187c97ae0cc9f7c3ed0
Tree-SHA512: 79af808c581ebb17d60aab8322b1debcc4182480b84eaedcbfac1e67c8b543c61df22789095742d67d732dba35e7e5fad77912385b695f89fb0f44f75db11560

465a583f9d

Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things

Instead of dropping the unnecessary UTXO based on whether the wallet did something,
do it based on whether two UTXOs are there.

fcdea8ad2a

Convert non-witness UTXOs to witness if witness sig created

If a witness signature was created when a non-witness UTXO is used,
convert the non-witness UTXO to a witness one.

fcefc6851a

Fix crash bug with duplicate inputs within a transaction
Introduced by #9049
833180f538
[qa] backport: Test for duplicate inputs within a transaction 0d49c82edd

Merge #14248: [0.17] Fix crash bug with duplicate inputs within a transaction

0d49c82edd4c2c92f8ebe215c057b0173a258d77 [qa] backport: Test for duplicate inputs within a transaction (Suhas Daftuar)
833180f538c7fa16b097022c7c0d4b4d2f09688b Fix crash bug with duplicate inputs within a transaction (Suhas Daftuar)

Pull request description:

  This is a backport of #14247.

Tree-SHA512: 4d3b6244d501a48f56a728c571dac9a346019a671434edac943f4f535ef8f94ec6bfd569a0585ad5e23a6e488ecd7e0079510cbb10a2a22f576eb36d73accb0c

c64128df58

depends: fix bitcoin-qt back-compat with older freetype versions at runtime

A few years ago, libfreetype introduced FT_Get_Font_Format() as an alias for
FT_Get_X11_Font_Format(), but FT_Get_X11_Font_Format() was kept for abi
backwards-compatibility.

Our qt bump to 5.9 introduced a call to FT_Get_Font_Format(). Replace it with
FT_Get_X11_Font_Format() in order to remain compatibile with older freetype,
which is still used by e.g. Ubuntu Trusty.

Github-Pull: #14348
Rebased-From: 430bf6c7a1a24a59050e7c9dac56b64b820edb43
Tree-SHA512: fd22b824e7251a7975d9e9222eff06d2b04ebf30e13aeccab580596c042b3abe2f62da1f0ef75106b0b171368ee1062ef2f459cfa435aa54826766a9005b80df

480d6bb078

doc: Update release-notes.md from upstream devwiki 786825c719

Merge #14157: [0.17] doc: merge upstream release-notes from bitcoin-core/bitcoin-devwiki

786825c719e40f8c73643fae4ea9e9dca454715f doc: Update release-notes.md from upstream devwiki (fanquake)

Pull request description:

  sipa [suggested in IRC](https://botbot.me/freenode/bitcoin-core-dev/2018-09-06/?msg=104094793&page=1) that now would be a good time to merge the release notes from the [bitcoin-devwiki](https://github.com/bitcoin-core/bitcoin-devwiki).

Tree-SHA512: 6d9631e12147b4e64f5382a64cceb71b84ca21bdb3fc516248de79968f7f26e74ab5d569e3767018581bcda4d5b8c8ec103b1795929e98f7e9c4d6e95379f7de

e1ed37edae

doc: Clean out release notes after release 0.17.0

Tree-SHA512: 0b641fdf4cf4ac6a6f9f5c1b45d65c4449b0d7bb777ba57498e389840ba7a37bfc0569ce5e70f0ac998785fc4eea600ecf6f7c7d83d86513997f4033bcc14a5d

5b47b8efd4

[wallet] Restore ability to list incoming transactions by label

Backport of PR 14411 to v0.17.

This change partially reverts #13075 and #14023.

Fixes #14382

89306ab0df

[doc] getblocktemplate: use SegWit in example f7dbcaa72f

Merge #14509: [0.17] doc: use SegWit in getblocktemplate example

f7dbcaa72f [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Backport of #14472

Tree-SHA512: ac0863b5f04abe2cbdbb44f376094aa6c224aecd6d3a87689a2bb5a939cb18503eab6e33bfb9814dd2129ddf1dae0118054afc8eb4c438bd390c172defab343b

1b5af2c177

qa: Add TestNode::assert_debug_log

Github-Pull: #14024
Rebased-From: fa3e9f7627784ee00980590e5bf044a0e1249999

06544faff0

[qa] Use correct python index slices in example test

Github-Pull: #14215
Rebased-From: 9dcb6763fb6851df6572e75278a41029fbfe8809

b72fbabe17

qa: Add some actual witness in rpc_rawtransaction

Github-Pull: #14052
Rebased-From: fae040010deda9404b15b214cec2a099fb831253

7ff32a6b98

scripted-diff: Pass node into p2p_segwit acceptance tests

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/(test_witness_block|test_transaction_acceptance)\((self\.nodes\[.\])\.rpc/\1(\2/g' test/functional/p2p_segwit.py
-END VERIFY SCRIPT-

Github-Pull: #14101
Rebased-From: 749ba35e7c9fbc21dbea27fd1be102b91313d132

96dc936862

scripted-diff: Use named arguments in feature_block

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e "s/sync_blocks\((.*?), (True|False), (1.?), /sync_blocks(\1, success=\2, reject_code=\3, reject_reason=/g" ./test/functional/feature_block.py
-END VERIFY SCRIPT-

Github-Pull: #14101
Rebased-From: b4d33096734d787b0e1d754064039cbb64ce8d61

73e538cf6a

qa: Use named args in some tests

Github-Pull: #14101
Rebased-From: fa782a308dbe7bc579c122f63c1c65666fc85e91

168efeaca6

test: Add tests for RPC help

Github-Pull: #14020
Rebased-From: 6af6d9b23dae4edd20c3dad49c835caabf3909b5

24d796a6cc

Test rpc_help.py failed: Check whether ZMQ is enabled or not.

Github-Pull: #14122
Rebased-From: 8dfc2f30dea6bde0f74d23691377f248966011ab

8bc1badada

qa: Premine to deterministic address with -disablewallet

Github-Pull: #14180
Rebased-From: faa669cbcd1fc799517b523b0f850e01b11bf40a

86fadee990

qa: Run all tests even if wallet is not compiled

Github-Pull: #14180
Rebased-From: fac95398366f644911b58f1605e6bc37fb76782d

f7adb32e38

Import CInv from correct module

Github-Pull: #13965
Rebased-From: a9cf5c9623ad547d9aeebea2b51c2afcfc0f3f4f

29899ecd36

doc/descriptors.md tweaks

Add some implementation details, and tweak phrasing in examples section to be
more explicit about how script expressions are used for matching.

Github-Pull: #14161
Rebased-From: eb494125624eb3d311c6b2e45ce403c61faddd62

5f51fd6d59

descriptors.md: Refer to descriptors as describing instead of matching
Github-Pull: #14161 Rebased-From: eeeaa29214ab99e7f491b21d21bf362a86a48305
703a24418c

Disable wallet and address book Qt tests on macOS minimal platform

macOS Qt minimal platform is frequently broken, and these are currently failing
with Qt 5.11.1.

The tests do pass when run on the full cocoa platform
(with `test_bitcoin-qt -platform cocoa`).

Github-Pull: #14011
Rebased-From: a3197c5294df4711bab0ff6dcdd061ceab115c7d

9461f98c53

[macOS] Remove DS_Store WindowBounds bytes object

Github-Pull: #14416
Rebased-From: 43719e0a3411e6a08e04908332cb44adfa00c6a2
Tree-SHA512: 0b5987abf34a8c62c3f704c4ca3c9837a23fbce11954740461833099157db94418886001993f9f1a0b3252c923bd049bc1e1d0f99d04205c889270755a8cd245

eb2cc84a31

doc: Update release notes for 0.17.0.1 248e5ec348
build: Bump version for 0.17.0.1 dc4923a71b
travis: Pin flake8 version to 3.5.0 f9fc08c5f8

Merge #14579: [0.17] travis: Pin flake8 version to 3.5.0

f9fc08c5f8 travis: Pin flake8 version to 3.5.0 (fanquake)

Pull request description:

  Pin flake8 version to 3.5.0 to fix the linters.

Tree-SHA512: 4f06d0aacbdfbbc6d090790aeea5185f2a61259381e586f4015bc0f8c0d0c8fec6156343a9587b8605bc776b39c080bd6584e6e9b685eaba3d90a58c726ac469

f13041f17b

Merge #14576: Release 0.17.0.1

dc4923a71bf64bd48708c7e4bd33765cdae68fdf build: Bump version for 0.17.0.1 (Wladimir J. van der Laan)
248e5ec348979c2d299b04adf93deaafd2b3b2b7 doc: Update release notes for 0.17.0.1 (Wladimir J. van der Laan)

Pull request description:

  Update release notes and bump version

Tree-SHA512: b1c3f77150d89450735c2a82cb5d859b11e7463cc3370c46f847a6f7b22318114cf4d3254eb3f6b15dc7204bc43d052781f97d02ef5a76d102d5d42a762be964

1476554d3b

Docs/Release notes: 0.17.0.1 is a minor release f046d846ae

Merge #14566: 0.17: qa backports

9461f98c53 Disable wallet and address book Qt tests on macOS minimal platform (Russell Yanofsky)
703a24418c descriptors.md: Refer to descriptors as describing instead of matching (Russell Yanofsky)
5f51fd6d59 doc/descriptors.md tweaks (Russell Yanofsky)
29899ecd36 Import CInv from correct module (Chun Kuan Lee)
f7adb32e38 qa: Run all tests even if wallet is not compiled (MarcoFalke)
86fadee990 qa: Premine to deterministic address with -disablewallet (MarcoFalke)
8bc1badada Test rpc_help.py failed: Check whether ZMQ is enabled or not. (Kvaciral)
24d796a6cc test: Add tests for RPC help (João Barbosa)
168efeaca6 qa: Use named args in some tests (MarcoFalke)
73e538cf6a scripted-diff: Use named arguments in feature_block (MarcoFalke)
96dc936862 scripted-diff: Pass node into p2p_segwit acceptance tests (MarcoFalke)
7ff32a6b98 qa: Add some actual witness in rpc_rawtransaction (MarcoFalke)
b72fbabe17 [qa] Use correct python index slices in example test (Suhas Daftuar)
06544faff0 qa: Add TestNode::assert_debug_log (MarcoFalke)

Pull request description:

  Just the test and doc changes from #14328 to prevent that one from piling up.

Tree-SHA512: 51c1e66d346cbf51bc67b2f365448620dd9992ba4ef70592c5eb489cd50a047dab8179c86db2cafe161d8b2aa04498cc760fb5deb7eef49b39272911c74227a9

76dd5257f9

Merge #14589: Docs/Release notes: 0.17.0.1 is a minor release

f046d846ae Docs/Release notes: 0.17.0.1 is a minor release (David A. Harding)

Pull request description:

  Suggested by @jnewbery in https://github.com/bitcoin-core/bitcoincore.org/pull/624#pullrequestreview-169055865

Tree-SHA512: 7e3068febaaf13cc31ef48e56ac7c36450fb1fb115e9940af603bb7cb740e93702e69be0eaaf06ff19866837bf29b4f08c1d9e3e55d98a65746a89a0dcab2b69

9e87d82e7f

qt: Revert "Force TLS1.0+ for SSL connections"

This reverts commit 15e26a6a9afe299b9ca6fced73b876644365879b, whose
purpose was to tweak the Qt configuration to force TLS, i.e., to
disable SSLv3, in Qt versions >= 5.5. However, the default behavior
of Qt >= 5.4 is to disable SSLv3 anyway [1], so the configuration
tweak is redundant.

With Qt 5.11.2, the configuration tweak is not only redundant but in
fact provokes a deadlock (#14359) due to Qt 5.11.2 being incompatible
with OpenSSL 1.1.1 [2]. Since the deadlock occurs at the early startup
stage of bitcoin-qt, it renders bitcoin-qt entirely non-functional
when compiled against OpenSSL 1.1.1 and Qt 5.11.2 (and possible future
combinations of OpenSSL and Qt versions).

This commit fixes #14359 by removing the redundant code.

[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3fd2d9eff8c1f948306ee5fbfe364ccded1c4b84
[2] https://bugreports.qt.io/browse/QTBUG-70956

Github-Pull: #14403
Rebased-From: 7d173c4cd1885ff5bcf9e5f8f7f712138dd8a445
Tree-SHA512: 71a34b13202c834c5ca73bcb9b70efff26c34e1aac3b954f098620b62c2be53a8e319929c4764a5b5cc5d0dd163ff70f4eb3a4f1f608363b7d23d1b16b25ddc7

0242b5afa4

Merge #14666: qt: Revert "Force TLS1.0+ for SSL connections" (0.17)

0242b5afa4ebb381d3a59a7246348a50d3a7fdbe qt: Revert "Force TLS1.0+ for SSL connections" (Tim Ruffing)

Pull request description:

  backports #14403 which fixes a crash on FC29

Tree-SHA512: 71a34b13202c834c5ca73bcb9b70efff26c34e1aac3b954f098620b62c2be53a8e319929c4764a5b5cc5d0dd163ff70f4eb3a4f1f608363b7d23d1b16b25ddc7

b0e88b8914

doc: Clean out release notes after 0.17.0.1

Tree-SHA512: c04192e3b93537f4b37f5ea55fd455b26dd7d902da3b5f8b59ef6fa4590cf413b72fc11bba330a8fd7fa3938b09e6c1d35171806ab5ce85d6b99681953c291a5

1e49fe450d

Merge #14441: [wallet] Backport(0.17): Restore ability to list incoming transactions by label

89306ab0df93bfdf5630910bc20b1eccb7379172 [wallet] Restore ability to list incoming transactions by label (Russell Yanofsky)

Pull request description:

  Backport of PR #14411 to v0.17.

  This change partially reverts #13075 and #14023.

  Fixes #14382

Tree-SHA512: 1f8300e1a79e826cd706561265b8788deef505fa510be1a76ed9a62e5fca37cf6a741423ac0e5de2a36d6e8b9f25f141885455aacacbbf6474814e6eae406a27

5150accdd2

[wallet] Ensure wallet is unlocked before signing

Github-Pull: #14310
Rebased-From: db15805668e923c3493d77122d20926496cf6a1a

bb90695551

Add autogen.sh in ARM Cross-compilation

autogen for the config files was missing.

Github-Pull: #14276
Rebased-From: 52beb9ed8876e3129360197ac632c1b59f910c55

85aacc41ba

add a test demonstrating an overflow in a deserialization edge case

Also add a test that the highest legal index is accepted.

Github-Pull: #14685
Rebased-From: 051faf7e9d4e32142f95f7adb31d2f53f656cb66

94065024c7

fix a deserialization overflow edge case

A specially-constructed BlockTransactionsRequest can overflow in
deserialization in a way that is currently harmless.

Github-Pull: #14685
Rebased-From: 6bed4b374daf26233e96fa7863d4324a5bfa99c2

5331ad0506

disallow oversized CBlockHeaderAndShortTxIDs

Otherwise we'd reply with a bogus BlockTransactionsRequest trying to
request indexes with overflowed deltas.

Github-Pull: #14685
Rebased-From: b08af10fb299dc3fdcd1f022619fb112c72e5d8e

2f9fd29321

qa: Add test to ensure node can generate all help texts at runtime
Github-Pull: #14658 Rebased-From: bbbbb3f8850907d413db4715c10ef6df055234f6
60f7a97930

Tests: Fix a comment

Github-Pull: #14632
Rebased-From: 086fc835718555bb332a807fe5794cb6cb4d1fef

96f15e8bb3

wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...)
Github-Pull: #13546 Rebased-From: a23a7f60aa07de52d23ff1f2034fc43926ec3520
91fa15aaeb

Fix listreceivedbyaddress not taking address as a string

Fixes #14173. Add the patch in #14173 and include a regression test.

Github-Pull: #14417
Rebased-From: d4d70eda339f6f74390b56edd4021e928bb588a7

fb9ad043f8

build: Remove illegal spacing in darwin.mk

Github-Pull: #14647
Rebased-From: 63c74d2d3abcb685c773c3ad1414da6ad062a55d

7edebedef1

build: Add bitcoin-tx.exe into Windows installer

Github-Pull: #14698
Rebased-From: 5c5902acc515c8f46ad73222cd57a29c4c13b92c

ec71f06a8d

travis: Remove deprecated sudo 542651cfb4

Merge #14328: [0.17] Backports

542651cfb4 travis: Remove deprecated sudo (MarcoFalke)
ec71f06a8d build: Add bitcoin-tx.exe into Windows installer (Chun Kuan Lee)
7edebedef1 build: Remove illegal spacing in darwin.mk (Jon Layton)
fb9ad043f8 Fix listreceivedbyaddress not taking address as a string (Eric Scrivner)
91fa15aaeb wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) (practicalswift)
96f15e8bb3 Tests: Fix a comment (fridokus)
60f7a97930 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke)
2f9fd29321 disallow oversized CBlockHeaderAndShortTxIDs (Kaz Wesley)
5331ad0506 fix a deserialization overflow edge case (Kaz Wesley)
94065024c7 add a test demonstrating an overflow in a deserialization edge case (Kaz Wesley)
85aacc41ba Add autogen.sh in ARM Cross-compilation (Walter)
bb90695551 [wallet] Ensure wallet is unlocked before signing (gustavonalle)

Pull request description:

Tree-SHA512: d82813134e5fc5437fe690127a4701d7ba66bf27799d7ecb1fbc2cc4dd81b6b3f708c1f314b725e8a3a6525ffa388299e277157f784f762256e01afb24822b25

9f556622c5

gui: explicitly disable "Dark Mode" appearance on macOS

Github-Pull: #14593
Rebased-From: cf2f4306fe26305b24bba8833af845ada3a42ec8

df5131bd41

Bugfix: RPC: Add address_type named param for createmultisig

Github-Pull: #14596
Rebased-From: d8bf1071cf819fb4e848bb832af8199f084e0434

de5e48a461

Throw error if CPubKey is invalid during PSBT keypath serialization
Github-Pull: #14690 Rebased-From: 4e4de10f69d5d705256cadfb15d76314dff16e77
5782fdcd8c

fix uninitialized read when stringifying an addrLocal

Reachable from either place where SetIP is used when our best-guess
addrLocal for a peer is IPv4, but the peer tells us it's reaching us at
an IPv6 address.

In that case, SetIP turns an IPv4 address into an IPv6 address without
setting the scopeId, which is subsequently read in GetSockAddr during
CNetAddr::ToStringIP and passed to getnameinfo. Fix by ensuring every
constructor initializes the scopeId field with something.

Github-Pull: #14728
Rebased-From: b7b36decaf878a8c1dcfdb4a27196c730043474b

6f04264bbb

add test demonstrating addrLocal UB

Github-Pull: #14728
Rebased-From: 8ebbef016928811756e46b9086067d1c826797a8

b90157891a

rpc: Make HTTP RPC debug logging more informative

Github-Pull: #14618
Rebased-From: 991248649b76a5a071e1360a700f3e2ecf3e1e1f

9666dbaf09

Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986)

Github-Pull: #14618
Rebased-From: ab8c6f24d28ea1d1e6258cf316b4b97a0baf2377

79358817e5

qa: Avoid race in p2p_invalid_block by waiting for the block request
Github-Pull: #14700 Rebased-From: fa2156820877caf70fc09c7e6244b7cde6ebaf29
f9db08e8ca

Merge #14835: [0.17] Further Backports

f9db08e8ca qa: Avoid race in p2p_invalid_block by waiting for the block request (MarcoFalke)
79358817e5 Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) (practicalswift)
9666dbaf09 rpc: Make HTTP RPC debug logging more informative (practicalswift)
b90157891a add test demonstrating addrLocal UB (Kaz Wesley)
6f04264bbb fix uninitialized read when stringifying an addrLocal (Kaz Wesley)
5782fdcd8c Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders)
de5e48a461 Bugfix: RPC: Add address_type named param for createmultisig (Luke Dashjr)
df5131bd41 gui: explicitly disable "Dark Mode" appearance on macOS (fanquake)

Pull request description:

  Backports #14593, #14596, #14618, #14690 and #14728 to the 0.17 branch.

Tree-SHA512: fcda4b75fcb71bb80cc8bde2a2b98ff5c0239dfa754ac980b1a91a90409502ac7678326399a4fc03a773074339dbf8b3d11750c91fe4302741a954745acfcca1

d8bc0ce1da

Remove stale comment in CalculateMaximumSignedInputSize 53dcf2b407
CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change 2a5cc40dc4

[tests] Add wallet_balance.py

Adds a test specifically to test the wallet's getbalance and
getunconfirmedbalance RPCs.

Github-Pull: #14845
Rebased-From: c1825b9d398b31967887c459c0fad9cf56cf95c6

67225e2fd7

Merge #14852: 0.17 backport: [tests] Add wallet_balance.py

67225e2fd7 [tests] Add wallet_balance.py (John Newbery)

Pull request description:

Tree-SHA512: 5a8707ddc7e11ac0b7b7dc27a73668acc7ff53f832d94a85930a28329ec5271da2b469e2b51d66746fa6ab54aa0221d49d215ec3434ea619352fcbacbb252883

252844329f

Merge #14851: [backport] fix assert crash when specified change output spend size is unknown

2a5cc40dc4 CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change (Gregory Sanders)
53dcf2b407 Remove stale comment in CalculateMaximumSignedInputSize (Gregory Sanders)

Pull request description:

  backport of #14380

Tree-SHA512: 42e261bd797d1938f8e041ccd10073ecd1d72695e2e4ce322e5a3ce262647e32108b01dde73361b6d2ac36438522ab3c4cd58ca072194f25011132437430cd27

924cf794e1

Merge #14196: [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary

fcefc6851a Convert non-witness UTXOs to witness if witness sig created (Andrew Chow)
fcdea8ad2a Drop the unnecessary UTXO based on the UTXOs present, not on earlier wallet things (Andrew Chow)

Pull request description:

  When we sign an input in a psbt that has a non-witness utxo but a witness signature is produced, we will now replace the non-witness utxo with the corresponding witness utxo. Furthermore, we should make sure that the correct UTXO type is used based on what UTXOs are there, not based on earlier wallet behavior.

  Note that this is PR'd to the 0.17 branch because the code here no longer exists in master.

Tree-SHA512: 882e9e4e9b77d6ac1743c35c0d59023aad6f4f19193398f97f2c6b81f6627d74e5220b1d674a0edba1ff2fc2a7f61afbf838d3faf0a964fccd3dee97c631aa47

3362a95be3

check that a separator is found for psbt inputs, outputs, and global map
Github-Pull: #14377 Rebased-From: 4fb3388db95f408566e43ebb9736842cfbff0a7d
a3fe125490

More concise conversion of CDataStream to string

Use .str() instead of .data() and .size() when converting CDataStream to
a string. Uses std::string, avoiding conversion to a C string.

Github-Pull: #14588
Rebased-From: fe5d22bc676f158e8d567d71edb3451118759d62

cfdd6b2f6c

Remove redundant txConst parameter to FillPSBT

Github-Pull: #14588
Rebased-From: 4f3f5cb4b142f0fcb36241fa33b52a257901dbee

a9eab081d5

New PartiallySignedTransaction constructor from CTransction

New constructor that creates a PartiallySignedTransaction from a
CTransaction, automatically sizing the inputs and outputs vectors for
convenience.

Github-Pull: #14588
Rebased-From: 65166d4cf828909dc4bc49dd68a58103d015f1fd

70ee1f8709

Add bool PSBTInputSigned

Refactor out a "PSBTInputSigned" function to check if a PSBT is signed,
for use in subsequent commits.

Also improve a related comment.

GitHub-Pull: #14588
Rebased-From: 53e6fffb8f5b10f94708d33d667a67cb91c2d09d

39ece4fc28

Simplify arguments to SignPSBTInput

Remove redundant arguments to SignPSBTInput -- since it needs several
bits of the PartiallySignedTransaction, pass in a reference instead of
doing it piecemeal. This saves us having to pass in both a PSBTInput and
its index, as well as having to pass in the CTransaction. Also avoid
redundantly passing the sighash_type, which is contained in the
PSBTInput already.

Github-Pull: #14588
Rebased-From: 0f5bda2bd941686620ef0eb90bd7ed973cc7ef73

ad94165db9

Refactor PSBTInput signing to enforce invariant

Refactor the process of PSBTInput signing to enforce the invariant that
a PSBTInput always has _either_ a witness_utxo or a non_witness_utxo,
never both.

This simplifies the logic of SignPSBTInput slightly, since it no longer
has to deal with the "both" case. When calling it, we now give it, in
order of preference: (1) whichever of the utxo fields was already
present in the PSBT we received, or (2) if neither, the
non_witness_utxo field, which is just a copy of the input transaction,
which we get from the wallet.

SignPSBTInput no longer has to remove one of the two fields; instead, it
will check if we have a witness signature, and if so, it will replace
the non_witness_utxo with the witness_utxo (which is smaller, as it is
just a copy of the output being spent.)

Add PSBTInput::IsSane checks in two more places, which checks for
both utxo fields being present; we will now give an RPC error early on
if we are supplied such a malformed PSBT to fill in.

Also add a check to FillPSBT, to avoid touching any input that is
already signed. (This is now redundant, since we should no longer
potentially harm an already-signed input, but it's harmless.)

fixes #14473

Github-Pull: #14588

db445d4e5a

Add regression test for PSBT signing bug #14473

Github-Pull: #14588
Rebased-From: e13fea975d5e4ae961faba36379a1cdaf9e50c1c

ff56bb9b44

Add test for conversion from non-witness to witness UTXO

Github-Pull: #14197
Rebased-From: 862d159d635c1de219d94e030b186a745fe28eb9

7bee41452b

Merge #14780: PSBT backports to 0.17

7bee41452b Add test for conversion from non-witness to witness UTXO (Pieter Wuille)
ff56bb9b44 Add regression test for PSBT signing bug #14473 (Glenn Willen)
db445d4e5a Refactor PSBTInput signing to enforce invariant (Glenn Willen)
ad94165db9 Simplify arguments to SignPSBTInput (Glenn Willen)
39ece4fc28 Add bool PSBTInputSigned (Glenn Willen)
70ee1f8709 New PartiallySignedTransaction constructor from CTransction (Glenn Willen)
a9eab081d5 Remove redundant txConst parameter to FillPSBT (Glenn Willen)
cfdd6b2f6c More concise conversion of CDataStream to string (Glenn Willen)
a3fe125490 check that a separator is found for psbt inputs, outputs, and global map (Andrew Chow)

Pull request description:

  This is a backport of #14588, #14377, and #14197's test to 0.17.

Tree-SHA512: 07535ec69a878a63b549e5e463345e233f34662dff805202614cf2ffc896c6d1981363e6d06d02db2e02d815075ad8ebdc5f93f637052cff8c8cbe6c8dfa096a

5d12143c73

fix converttopsbt permitsigdata arg, add basic test

Github-Pull: #14356
Rebased-From: 88a79cb436b30b39d37d139da723f5a31e9d161b

7a590d8390

rpc: Fix wallet unload during walletpassphrase timeout
Github-Pull: #14453 Rebased-From: 321decf
75b5d8c4ea

build: bump version to 0.17.1

Also update man pages.

Tree-SHA512: 826f3c9ad1e49902ee2f1710a4329388c0a9298a359971f21130bf8f390d4a7b744d010f04eb109666ceb28d0053b9fa7ec088caaa4e4cc38509526457086d40

6042dfe008

qa: Ensure wallet unload during walletpassphrase timeout

0.17 branch doesn't include #12493 which changed encryptwallet behavior. For that
reason the test is adjusted.

Github-Pull: #14453
Rebased-From: 8907df9

dcb032dcdf

Merge #14878: 0.17: Further backports

7a590d8390ef2158509c4fc08b84dac71f59e1fb fix converttopsbt permitsigdata arg, add basic test (Gregory Sanders)

Pull request description:

  Ooff, we missed some backports that were tagged.

  Checked:

  * In 7a590d8 (clean cherry-pick): The test changes fail without the code changes

Tree-SHA512: 9996886113dfcd8efa91f5436bc0f3507c81579861543611367bc3403868019fb1e45832c3f994f12278edb1c0c850e21f2f88e46a6981f45a11c4d61dcedaf9

8b8b3a9a5f

Merge #14880: 0.17: Backport #14453

dcb032dcdf qa: Ensure wallet unload during walletpassphrase timeout (João Barbosa)
75b5d8c4ea rpc: Fix wallet unload during walletpassphrase timeout (João Barbosa)

Pull request description:

  Backport #14453 to 0.17

Tree-SHA512: fce0adccbb07b6635bb773a71beb4a9b814bceb77bbe7bbc5bcb7d151aabb1148c791622f58c990afe202012ca1971cd466cb536fc6f37e22cdc58738720b593

abae8aeff1

Stop requiring imported pubkey to sign non-PKH schemes

Github-Pull: #14424
Rebased-From: 2f6b466aeb6d4c88ab2e0e8b2a402be0743608b5

89a9a9d938

Merge #14889: [0.17] Backport #14424 (Stop requiring imported pubkey to sign non-PKH schemes)

89a9a9d9385bbf291849874adc33a270b28fcac4 Stop requiring imported pubkey to sign non-PKH schemes (Pieter Wuille)

Pull request description:

  Github-Pull: #14424
  Rebased-From: 2f6b466aeb6d4c88ab2e0e8b2a402be0743608b5

Tree-SHA512: 1ea10dee66626f04918f197cd7c4949a836fa49c8f676f276b2328f8d79389059db7b30fc04d4c4bf8209f6a8d21f3ea49a017ddc7623eca6b7e6efc2fe0d749

c6e4a1fca5

doc: Fill in authors and changelog for 0.17.1 release notes

Tree-SHA512: dc23ae43e81ad379b48bb8dc6da21cde647a7edc778563b8b8266dfe84d9baa70bf4565915e276ea0e14aa96ce677547494da0aadeebfcc961f53430c7bb84ea

ef70f9b52b

rpc: Avoid creating non-standard raw transactions

Github-Pull: #14890
Rebased-From: fa4c8679ed94f215ce895938f7c3c169a2ce101e

46c162df47

importmulti: Don't add internal addresses to address book

Github-Pull: #14679
Rebased-From: 7afddfa8cefd01249ad59cf2370e7cec90b34f6f

ae1b6756c9

Merge #14900: [backport] #14679 importmulti: Don't add internal addresses to address book

ae1b6756c importmulti: Don't add internal addresses to address book (Gregory Sanders)

Pull request description:

Tree-SHA512: 749e4864862bc3402a0fad200578804ce6577b4d954fd3e741191b4c941df28d54f98422f90e7fdf9bdf9c01e53ec36cf970e61d22ccc0478771285dd8cef6a0

a057cc08fd

Merge #14893: 0.17 [Backport 14890] rpc: Avoid creating non-standard raw transactions

46c162df47 rpc: Avoid creating non-standard raw transactions (MarcoFalke)

Pull request description:

Tree-SHA512: f34678637c8b6559e5c0c2790b682af562479239b92be96e0d41806bade136866f9748487a021eb8c62b6a5027b0a1a2cbdee930243eac93edabef60cbd54eac

e11856515e

doc: Clean out release notes post-0.17.1

Tree-SHA512: 0cd6e97156da2dea9a9b557083d8140c17f85f6e718d5fcb73aa67460480b6437b665fad147bf4eacd13570aeb25a29f28c35b7fb0365ae630b2edf05901a431

fd616d8d08

Add PSBT documentation

Github-Pull: #13941
Rebased-From: 19efc01aec6b0d8750413fa1b721e04aaecf8f73

ddd008dbef

doc: Fix PSBT howto and example parameters

* Remove outdated reference to replaceable parameter
* Fix address reference
* Unify quotation and italicization of parameters
* Fix PSBT reference

Github-Pull: #14319
Rebased-From: 78542a3f36381fe96f60708834c8378042e3bab6

88c566a13f

Fix minor grammar error in doc

Github-Pull: #15012
Rebased-From: 72b63bc9054f7742a9b12ea29b21770b5e437092

fa0c76adee

fix testmempoolaccept CLI syntax

`testmempoolaccept "hexstring"` will give a "JSON parse error". The correct syntax is `testmempoolaccept \[\"hexstring\"\]` (but seems escaping is not displayed in other areas so leaving backspaces out).

Github-Pull: #14966
Rebased-From: b74a52192bcefea6fdc38f244e9500ce5868a0b5

b4602e3240

doc: update NetBSD build instructions for 8.0

Github-Pull: #14944
Rebased-From: be5ca825a38bc71c3a79ef35335e9c2e597ad225

b138b4abff

Merge #15055: [0.17] Backport #14944

b138b4abff doc: update NetBSD build instructions for 8.0 (fanquake)

Pull request description:

  Backports #14944 to the 0.17 branch.

Tree-SHA512: b169ff9c42cca3573b972b43adaf0556d5a198a755cd4c1a69c4c557b7cab6cf977c24d575c8802869d157d2bb0dff76c5d7f1e7647a58a4670f252614dab421

fa941016e8

gui: Favor macOS show / hide action in dock menu

Github-Pull: #14133
Rebased-From: ee3a494f37d6a459a5d935446ba08d69ea310b9b

298dc15686

Clean systray icon menu for -disablewallet mode

Ref #3392

Github-Pull: #14383
Rebased-From: 36323e2ac6cca134de47b06c3f6403de91ee9eda

d2ed162ce0

Remove obj_c for macOS Dock icon setting

Qt `setWindowIcon()` does this work.

Github-Pull: #14597
Rebased-From: 53bb6be3f8a50ee9e5c4d7e9155236152e7c4b7c

4d4bc37df9

Use Qt signal for macOS Dock icon click event

This moves the Dock icon click reaction code to the common place and
allows some cleanup in obj_c code.

According to the Apple's docs `class_replaceMethod` behaves as
`class_addMethod`, if the method identified by name does not yet exist;
or as `method_setImplementation`, if it does exist.

Github-Pull: #14597
Rebased-From: 2464925e7be832d4926b6204169bbbc1646c6368

90347141bd

Remove obj_c for macOS Dock icon menu

Qt `setAsDockMenu()` does this work.

Github-Pull: #14597
Rebased-From: 6b1d2972bf9a40f97ba3a5c95831fd179b1054cf

0c2fb87dc1

qt: Add GUIUtil::bringToFront

Github-Pull: #14123
Rebased-From: 5796671e1dd8a2d0b1e750c2dce19a10af624095

ac73c7d433

qt: Use GUIUtil::bringToFront where possible

Github-Pull: #14123
Rebased-From: 6fc21aca6d5e16c3ece104fec8e5b3df116893b4

c470bbd19d

qt: All tray menu actions call showNormalIfMinimized

Github-Pull: #14123
Rebased-From: 0a656f85a9c694f25b06c6464d6e986816eecd58

27beb83222

Merge #15053: [0.17] Backport #14966

b4602e324056391138a1a536bf15a45ebf5b0c61 fix testmempoolaccept CLI syntax (1Il1)

Pull request description:

  Backports #14966 to the 0.17 branch.

Tree-SHA512: 91ab186d612a11454d1a7cbe6d4251813e42eb438b5e2e0e1dfdb76c352d866fd4d5f04cc0cb696ffb7585f24babbfeb79e73481cc669e4b944712a743e822d3

623a19bc2b

Merge #14945: [0.17] Backport: PSBT documentation

fa0c76adee Fix minor grammar error in doc (bitcoinhodler)
88c566a13f doc: Fix PSBT howto and example parameters (priscoan)
ddd008dbef Add PSBT documentation (Pieter Wuille)

Pull request description:

  Backports #13941, #14319 and #15012 to 0.17.

Tree-SHA512: 9fbc900aa98f948260273970c4e51e69088460e153fd7dae8f3ddebf37c68ecdf1cd02f1f32759c638e5aecbb89529631e8cc7cad0e6370dbc21e70baa6e9145

16521ce086

Merge #15065: 0.17: GUI Backports #14123 #14133 #14383 #14597

27beb8322297d70dccc4db0605b22470e50e9010 qt: All tray menu actions call showNormalIfMinimized (João Barbosa)
c470bbd19db048e771ad7495b24b7d09e63e9e1b qt: Use GUIUtil::bringToFront where possible (João Barbosa)
ac73c7d433e609f4516136c543623c6c6f0245e2 qt: Add GUIUtil::bringToFront (João Barbosa)
0c2fb87dc1ec1b13fa7abab038f6c52ce0c749e9 Remove obj_c for macOS Dock icon menu (Hennadii Stepanov)
90347141bdb4020875c55ff51375aada46a1a4d9 Use Qt signal for macOS Dock icon click event (Hennadii Stepanov)
4d4bc37df983a8c8bb7a2d926521836e4ce8c913 Remove obj_c for macOS Dock icon setting (Hennadii Stepanov)
d2ed162ce0c83782d6a66cfdbe1c6aedcb485697 Clean systray icon menu for -disablewallet mode (Hennadii Stepanov)
298dc15686ce38855e41543c833b75e31bf89bce gui: Favor macOS show / hide action in dock menu (João Barbosa)

Pull request description:

  Backport #14123 #14133 #14383 and #14597 to 0.17 branch to fix https://github.com/bitcoin/bitcoin/issues/13606#issuecomment-449846983.

Tree-SHA512: 543c80e7e2130870e801e0c9a69b06b9eea27c288478fc5dddeb662f7f3ec5b56b30916e5a9a629fced3fffcb8be77e2cd155e75cfd0a4392299add9730840f4

5ff7b372cd

gui: Fix for Incorrect application name when passing -regtest

Github-Pull: #15085
Rebased-From: cc341adbbb7584d3110a5151baf1ba4053aa2ed1

59dd855d2d

Merge #15094: 0.17: Backport for #15085

59dd855d2de77cd72a2b3190a825783ff3627e17 gui: Fix for Incorrect application name when passing -regtest (Ben Carman)

Pull request description:

  Changes the application name to `Bitcoin-Qt-regtest` when instead of `Bitcoin-Qt-testnet`

  Fixes #15079

Tree-SHA512: 96a8ee5b1906e81f087b3523a59b0d66a9ac0d0cfeb3b48c0762bcac6048c4c17998fc2bf83cff866aacd24f1860c578a2d93baa61e8c2638d265b30f8c2470a

0a0b2ea11f

rpc: Make unloadwallet wait for complete wallet unload
Github-Pull: #14941 Rebased-From: c37851d
0cd9ad208c
Remove errant past from walletcreatefundedpsbt for nLocktime replaceability
Github-Pull: #15213 Rebased-From: 85f0ca95f3b57d9714a753882ea22fcd6a4139fb
c42f4177ce

Update zmq to 4.3.1

Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250

Github-Pull: #15188
Rebased-From: 3046e5fc019c7276300c65500fb4701e70f6c9d8

8418707286

Merge #15251: [0.17] doc: Remove errant paste from walletcreatefundedpsbt for nLocktime replaceable

c42f4177ce Remove errant past from walletcreatefundedpsbt for nLocktime replaceability (Gregory Sanders)

Pull request description:

  Backports #15213 to the 0.17 branch.

Tree-SHA512: f676e0b510b3ae76bf2ae46c7be289837a6d0152972c551ad6a837aab57ec74ee529c309163c8b7e3df446c2f30f148e920702dc31504cc239f99ad4a4607114

1220b91fa7

Merge #15252: [0.17] Backport: Update zmq to 4.3.1

84187072860707ddf06ebd629f30f12a0398c2cb Update zmq to 4.3.1 (Dimitris Apostolou)

Pull request description:

  Backports #15188 to the 0.17 branch.

  Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-6250.

Tree-SHA512: f8047a22430dcc92ef713e72281286c4cad2fbe3cd6880cb16b9f8c83bdc481a72539ff5fd373133ac006409ca083db68368e56df47a50798963e77fb3e579f2

09a9238c04

Merge #15002: 0.17: Backport #14941

0cd9ad208c327127cc4616ccdc37557fad3cf381 rpc: Make unloadwallet wait for complete wallet unload (João Barbosa)

Pull request description:

  #14941 makes `unloadwallet` a synchronous call meaning that it waits for the wallet to fully unload/delete.

Tree-SHA512: df7a490306ee2cca399129a4ebfba4b19b65fe67d1657ec3518352fe453327cb347010f94cf7fe4a60aeb51c928cb9ad6b24c40123fd0b9dc0aab5920a59f48d

30db5cc641

[0.17] [Doc] Backport release note about PSBT doc 807add9f5d

Merge #15315: [0.17] [Doc] Backport release note about PSBT doc

807add9f5d3d4a7d198c3aefd67b195382bb748f [0.17] [Doc] Backport release note about PSBT doc (David A. Harding)

Pull request description:

  #15314 removes a release note from master for a doc that is backported to 0.17.  This adds the note to the 0.17 branch.  The only difference in the text is that the `master` in the URL has been changed to `0.17`.

Tree-SHA512: b81af561ad6cf608e3b957d7c50fe6d9b0818cfbd16313599d6dadb4b60e9e3345fef949c4e2ed16cdecfd62201e3e099907f1510e4d16a9f33625163c84c5a2

392d1382c1

geekastute closed this on Feb 25, 2019
fanquake locked this on Feb 25, 2019

Contributors

geekastute