[rpc] deriveaddress: rename range 'begin' argument to 'start' #15496

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/02/begin_start changing 3 files +7 −7

Sjors commented at 4:22 PM on February 27, 2019: member

This changes range: {begin: ..., end: ...} parameter for deriveaddress to range: {start: ..., end: ...} to be consistent with importmulti.
[rpc] deriveaddress: rename range 'begin' argument to 'start' 483b1c05c4
Sjors commented at 4:23 PM on February 27, 2019: member

Pointed out by @instagibbs in the original PR. Would be nice to get this into 0.18. Fixed a grammar nit as well.
instagibbs commented at 4:29 PM on February 27, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15496/commits/483b1c05c4f72bd52cb576625ab714f95958b12f
promag commented at 4:30 PM on February 27, 2019: member
- initially was start
- then I've suggested begin #14667 (review)
- then @instagibbs noted the inconsistency #14667 (review)
After consistency, personally I prefer begin/end and start/stop.
Sjors commented at 4:32 PM on February 27, 2019: member

I can change importmulti to use begin ... end instead if people prefer. I find start ... end and begin ... end fine, but not start ... stop.
MarcoFalke added the label Docs on Feb 27, 2019
MarcoFalke added this to the milestone 0.18.0 on Feb 27, 2019
laanwj commented at 6:16 PM on February 27, 2019: member

Good catch. Makes sense to at least be consistent between calls.
meshcollider commented at 8:21 PM on February 27, 2019: contributor

utACK https://github.com/bitcoin/bitcoin/commit/483b1c05c4f72bd52cb576625ab714f95958b12f
sipa commented at 8:29 PM on February 27, 2019: member

Given that both importmulti and deriveaddress are new in 0.18, would it be worthwhile to make it compatible with scantxoutset (which uses a parameter called "range", but not start position)?
instagibbs commented at 8:31 PM on February 27, 2019: member

@sipa importmulti would have collisions if you try to import 100, then another 100?
sipa commented at 8:34 PM on February 27, 2019: member

@instagibbs Well clearly importmulti should support a range that doesn't start at 0. My suggestion is whether we want to consider naming the argument "range" rather than stop or end, to be compatible with scantxoutset (which is already in 0.17). What about "range" : [start,stop] for start-stop, and "range" : stop for 0-stop?
sipa commented at 10:55 PM on February 27, 2019: member

@instagibbs See #15497.
DrahtBot commented at 11:48 PM on February 27, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15497 (Consistent range arguments in scantxoutset/importmulti/deriveaddresses by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj removed this from the milestone 0.18.0 on Feb 28, 2019
laanwj commented at 2:40 PM on February 28, 2019: member

Replacing this with #15497 in the 0.18 milestone.
Sjors closed this on Feb 28, 2019
MarcoFalke referenced this in commit a6d7026a45 on Mar 1, 2019
dzutto referenced this in commit f5e52489c7 on Dec 1, 2021
MarcoFalke locked this on Dec 16, 2021