refactor: Remove unused function #15618

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-refRem changing 1 files +0 −20
  1. MarcoFalke commented at 5:33 pm on March 18, 2019: member
    Oversight of kallewoof and mine in #13541 (review)
  2. refactor: Remove unused function fa5c511a83
  3. MarcoFalke added the label Refactoring on Mar 18, 2019
  4. laanwj commented at 6:34 pm on March 18, 2019: member

    This should never have been merged in the first place, I’m happy this concerns an unused function but we should mark consensus-critical files at some point to prevent wallet and RPC PRs from affecting consensus-critical code accidentally.

    utACK fa5c511a832632b964617776eb6c3535bb2bd893

  5. promag commented at 6:43 pm on March 18, 2019: member
    utACK fa5c511.
  6. jnewbery commented at 6:59 pm on March 18, 2019: member
    utACK fa5c511a832632b964617776eb6c3535bb2bd893
  7. laanwj merged this on Mar 18, 2019
  8. laanwj closed this on Mar 18, 2019

  9. laanwj referenced this in commit e45b7f20e6 on Mar 18, 2019
  10. MarcoFalke deleted the branch on Mar 18, 2019
  11. kallewoof commented at 11:58 pm on March 18, 2019: member

    Post-merge utACK. Terribly sorry about that. I must’ve screwed up something between branches.

    I went through the merged code to make sure no other accidental code was included as well, and couldn’t find any, FWIW.

  12. luke-jr referenced this in commit da80965597 on Apr 22, 2019
  13. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me