Oversight of kallewoof and mine in #13541 (review)
refactor: Remove unused function #15618
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-refRem changing 1 files +0 −20-
MarcoFalke commented at 5:33 PM on March 18, 2019: member
-
refactor: Remove unused function fa5c511a83
- MarcoFalke added the label Refactoring on Mar 18, 2019
-
laanwj commented at 6:34 PM on March 18, 2019: member
This should never have been merged in the first place, I'm happy this concerns an unused function but we should mark consensus-critical files at some point to prevent wallet and RPC PRs from affecting consensus-critical code accidentally.
utACK fa5c511a832632b964617776eb6c3535bb2bd893
-
promag commented at 6:43 PM on March 18, 2019: member
utACK fa5c511.
-
jnewbery commented at 6:59 PM on March 18, 2019: member
utACK fa5c511a832632b964617776eb6c3535bb2bd893
- laanwj merged this on Mar 18, 2019
- laanwj closed this on Mar 18, 2019
- laanwj referenced this in commit e45b7f20e6 on Mar 18, 2019
- MarcoFalke deleted the branch on Mar 18, 2019
-
kallewoof commented at 11:58 PM on March 18, 2019: member
Post-merge utACK. Terribly sorry about that. I must've screwed up something between branches.
I went through the merged code to make sure no other accidental code was included as well, and couldn't find any, FWIW.
- luke-jr referenced this in commit da80965597 on Apr 22, 2019
- DrahtBot locked this on Dec 16, 2021
