-wallet is a "network-only" option but -walletdir is not #15630

issue MarcoFalke opened this issue on March 20, 2019

MarcoFalke commented at 8:48 PM on March 20, 2019: member

Any reason for this?

https://github.com/bitcoin/bitcoin/blob/2d46f1be0c3c8b7287aa1f62bb1f5b4a8d00ff6e/src/util/system.cpp#L316-L326
MarcoFalke added the label Utils/log/libs on Mar 20, 2019
fanquake deleted a comment on Mar 21, 2019
promag commented at 10:34 PM on March 21, 2019: member

#11862 (Network specific conf sections) came after #11466 (Specify custom wallet directory with -walletdir param) and in #11862 -walletdir is never mentioned.

I think it makes sense to add -walletdir.
luke-jr commented at 10:42 PM on March 21, 2019: member

It's not inherently broken to put wallets for different networks in the same directory, so it makes sense to allow a shared -walletdir...
promag commented at 10:47 PM on March 21, 2019: member

@luke-jr but wallets are relative to -walletdir so it could be confusing no?
luke-jr commented at 11:01 PM on March 21, 2019: member

Maybe. I suppose without -walletdir we do have network-separate wallet dirs.
MarcoFalke commented at 5:58 PM on March 22, 2019: member

See also discussion in " Wallet file should not be reused across chains #12805 "
hebasto commented at 3:31 AM on April 21, 2019: member

@MarcoFalke @meshcollider Could this issue also be labeled "Wallet"?
fanquake added the label Wallet on Apr 21, 2019
meshcollider closed this on Nov 22, 2019
sidhujag referenced this in commit 65781f441a on Nov 23, 2019
sidhujag referenced this in commit d0ca2e8c76 on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021
Munkybooty referenced this in commit 47f21a4962 on Jun 7, 2022
Munkybooty referenced this in commit bab15c1b64 on Jun 8, 2022
Munkybooty referenced this in commit a3b449371e on Jun 16, 2022
Munkybooty referenced this in commit fbb2ae50c0 on Jun 16, 2022

Contributors

Labels

Wallet Utils/log/libs

Linked (view graph)

#17447 wallet: Make -walletdir network only