[wallet] encryptwallet should fail for watch-only wallet #15635

1. 
   Sjors commented at 4:21 pm on March 21, 2019: member

   Create a wallet as follows:

   0$ bitcoin-cli createwallet "watchonly" true
   1$ bitcoin-cli -rpcwallet=watchonly getwalletinfo
   2{
   3   ...
   4   "private_keys_enabled": false
   5}
   

   The following should fail, but doesn’t:

   0$ bitcoin-cli -rpcwallet=watchonly encryptwallet 1234
   1wallet encrypted; The keypool has been flushed and a new HD seed was generated (if you are using HD). You need to make a new backup.
   

   It partially fails silently, because it doesn’t actually add a seed. But it does ask for a password when calling dumpwallet, which doesn’t make sense because we currently don’t encrypt anything other than private keys.

2. MarcoFalke renamed this:
   [wallet] encryptwallet should fail for watch-only walet
   [wallet] encryptwallet should fail for watch-only wallet
   on Mar 21, 2019
3. fanquake added the label Wallet on Mar 21, 2019
4. laanwj referenced this in commit 52ec4c64e8 on Jun 5, 2019
5. 
   Sjors commented at 9:11 am on October 29, 2019: member

   Fixed by #16144. Thanks @mrwhythat!
6. Sjors closed this on Oct 29, 2019

   ---

7. Munkybooty referenced this in commit c25869dbfb on Oct 17, 2021
8. Munkybooty referenced this in commit eba4cbddb4 on Oct 25, 2021
9. Munkybooty referenced this in commit 29a2c36f7e on Oct 26, 2021
10. Munkybooty referenced this in commit b3235c5420 on Oct 26, 2021
11. Munkybooty referenced this in commit 5d12f44d55 on Nov 9, 2021
12. pravblockc referenced this in commit 6f127d350f on Nov 18, 2021
13. MarcoFalke locked this on Dec 16, 2021

Contributors
Sjors

Labels
Wallet