Better support for mainframes and EBCDIC users in general #15715

pull scravy wants to merge 3 commits into bitcoin:master from scravy:cater-mainframes-and-ebcdic-users changing 503 files +31933 −31933
  1. scravy commented at 1:11 PM on April 1, 2019: contributor

    As can be seen in the photograph of a typical mainframe keyboard:

    keyboard-029

    These users do not have access to curly braces. To welcome contributors also from the realm of mainframe super computing, bitcoin should use some of the lesser known features of C++: Digraphs.

    This pull request replaces non-comment and non-string curly braces with their equivalent digraph representations <% and %>. I had to adjust the check-rpc-mappings.py linter a bit as it was not robust enough to deal with the full spectrum of expressivity that C++ offers.

    This change should help users using EBCDIC or rather esoteric codepages like DIN_66003.

    Unfortunately Trigraphs were removed from C++17, which is why I restrained from replacing symbols in string literals and comments.

  2. Replace curly braces with digraphs 621ea2f27c
  3. Fix check-rpc-mappings.py 32c0ea4363
  4. Satisfy white-space linter 33a95273fa
  5. fanquake added the label Refactoring on Apr 1, 2019
  6. MarcoFalke commented at 1:39 PM on April 1, 2019: member

    Concept ACK. Though reviewing a +31933-31933 diff is a bit daunting, so I'd prefer a scripted-diff.

  7. scravy commented at 2:17 PM on April 1, 2019: contributor

    Aww shoot, one of the travis build spuriously errored out: https://travis-ci.org/bitcoin/bitcoin/builds/514144261

    I guess the validity of the change can be checked by building without this patch and with, the binary should not change a bit.

  8. laanwj commented at 2:17 PM on April 1, 2019: member

    :joy:

  9. DrahtBot commented at 3:56 PM on April 1, 2019: member

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  10. DrahtBot added the label Needs rebase on Apr 1, 2019
  11. scravy commented at 11:38 AM on April 2, 2019: contributor

    Happy April Fool's Day!

  12. scravy closed this on Apr 2, 2019

  13. laanwj removed the label Needs rebase on Oct 24, 2019
  14. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me