Bitcoin-Qt project file - used identifiers (windows / mac) #1573

issue Diapolo opened this issue on July 9, 2012
  1. Diapolo commented at 8:43 PM on July 9, 2012: none

    We use the keyword windows a lot in the project file, but I'm not sure if this is supported / correct. I was not able to find a reliable source that sheds some light on my question.

    See: http://doc.qt.nokia.com/4.7-snapshot/qmake-advanced-usage.html

    There is always win32 mentioned. Same for mac, which should perhaps be macx.

    Anyway, I tried replacing all occurrences of windows with win32 and it compiles fine on my local setup. Perhaps a main dev can take a look at this.

  2. laanwj commented at 5:27 AM on July 10, 2012: member

    It seems to work fine right now. Maybe WINDOWS is general windows, and WIN32 is 32 bit apecific?

  3. laanwj commented at 12:27 PM on July 10, 2012: member
  4. Diapolo commented at 12:29 PM on July 10, 2012: none

    And I don't see windows mentioned over there in the posting.

  5. Diapolo commented at 11:27 PM on September 28, 2012: none

    Alright, no more mac occurances are in the pro-file now. Next thing I'd like to do is switch all windows to win32 and as we now have the pull tester this should be easy to verify it breaks nothing :).

  6. Diapolo commented at 4:08 PM on January 6, 2013: none

    Should be fixed by #2109.

  7. Diapolo commented at 1:07 AM on January 26, 2013: none

    Resolved, so closing this.

  8. Diapolo closed this on Jan 26, 2013

  9. lateminer referenced this in commit f973fb6fd6 on May 6, 2020
  10. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me