Fixes #1452.
Until we can make the logic water-tight and are notified in every case the balance might have changed (either due to blocks maturing, or outputs spent), remove the premature optimization and simply recompute the balance every half a second when the number of blocks changed.
Shouldn't make any impact on performance in practice.
If this works very cool, currently preparing a test!
One thing (unrelated to the problem), could you harmonize the order in checkBalanceChanged() and updateTransaction() when the emit is called. Either first update the vars and then emit or first emit the signal and then update the vars. I dislike such small coding discrepances, can't help.
Fixes #1452. Until we can make the logic water-tight *and* are notified in every
case the balance might have changed, remove the premature optimization and
simply recompute the balance every half a second when the number of blocks changed.
Changed the order. It indeed makes sense to first update the variables and then emit the signal, so that calls to getXXX in the signal handler return the new value.
I currently can't verify as my testnet coins are immature, so I can't empty my wallet -_-.
I made a test on testnet, which was succesfull a day ago and a few seconds ago on a mainnet wallet, which also works like expected. Amounts get cleanly updated.
ACK