doc: Clarify sendrawtransaction::maxfeerate==0 help #15760

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1904-docRpcRaw changing 1 files +3 −1

MarcoFalke commented at 10:01 PM on April 5, 2019: member

Used a lot in e.g. the tests: git grep 'maxfeerate=0)' test
DrahtBot added the label Docs on Apr 5, 2019
DrahtBot added the label RPC/REST/ZMQ on Apr 5, 2019
doc: Clarify sendrawtransaction::maxfeerate==0 help fa49db7eac
MarcoFalke force-pushed on Apr 6, 2019

jonatack commented at 4:11 PM on April 7, 2019: member

ACK https://github.com/bitcoin/bitcoin/pull/15760/commits/fa49db7eacecfe0657797aa4aa3c783c4527e19f

Change adds: "Set to 0 to accept any fee rate.\n". Note that in lines 1094 and 1176 it is expressed a bit differently: "To allow a transaction with high fees, set maxfeerate to 0."

Output tested by logging the output of from_node.sendrawtransaction() in test/functional/feature_fee_estimation.py:

sendrawtransaction "hexstring" ( maxfeerate )

Submits raw transaction (serialized, hex-encoded) to local node and network.

Also see createrawtransaction and signrawtransactionwithkey calls.

Arguments:
1. hexstring     (string, required) The hex string of the raw transaction
2. maxfeerate    (numeric or string, optional, default=0.10) Reject transactions whose fee rate is higher than the specified value, expressed in BTC/kB.
                 Set to 0 to accept any fee rate.

promag commented at 2:26 PM on April 8, 2019: member

ACK fa49db7.
MarcoFalke merged this on Apr 8, 2019
MarcoFalke closed this on Apr 8, 2019
MarcoFalke referenced this in commit 297ea51caf on Apr 8, 2019
MarcoFalke deleted the branch on Apr 8, 2019
jasonbcox referenced this in commit 520ccc3a35 on Oct 26, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels