Doc/Trivial change key name duration->duration-ms for getrpcinfo #15769

pull crackercracked wants to merge 1 commits into bitcoin:master from crackercracked:fix-issue-15555-change-duration-key-getrpcinfo changing 1 files +1 −1

crackercracked commented at 2:20 AM on April 8, 2019: none
To address issue: #15731 Just changing the key value of Json from duration to duration_ms to self-indicate the unit of time

Has run make check to make sure all units test passed.

Pull requests without a rationale and clear improvement may be closed immediately.

Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly.
- Any test improvements or new tests that improve coverage are always welcome.
- All other changes should have accompanying unit tests (see src/test/) or functional tests (see test/). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change.
- Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed.
- Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible.
- Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they significantly improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the developer notes, stylistic code changes are usually rejected.
Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time.
change key name duration->duration-ms for getrpcinfo 0e96176f2b
fanquake added the label Docs on Apr 8, 2019
crackercracked closed this on Apr 8, 2019

in src/rpc/server.cpp:311 in 0e96176f2b

 307 | @@ -308,7 +308,7 @@ static UniValue getrpcinfo(const JSONRPCRequest& request)
 308 |      for (const RPCCommandExecutionInfo& info : g_rpc_server_info.active_commands) {
 309 |          UniValue entry(UniValue::VOBJ);
 310 |          entry.pushKV("method", info.method);
 311 | -        entry.pushKV("duration", GetTimeMicros() - info.start);

promag commented at 3:15 PM on April 8, 2019:

FYI this is considered breaking change, however you could add a new field. Also, ms stands for milliseconds, and the unit here is microseconds.

DrahtBot locked this on Dec 16, 2021

Contributors

crackercracked

promag

Labels

Docs

Linked (view graph)

#15731 Add getrpcinfo doc