Should this code run even if tx is not new and not update? #15781

https://github.com/bitcoin/bitcoin/blob/a7b486d6f8df868ff5b93b7152e4f7ce810fca78/src/wallet/wallet.cpp#L977-L995

Shouldn't this be more like this:

    // Need to write to disk?
    if (!fInsertedNew && !fUpdated)
        return false;
    // Write to disk
    if (!walletdb.WriteTx(wtx))
        return false;

No, currently NotifyTransactionChanged and -walletnotify are called if !fInsertedNew && !fUpdated.

No, currently NotifyTransactionChanged and -walletnotify are called if !fInsertedNew && !fUpdated.

May I know what the rationale for running notify would be if it's not a new and not an updated tx?

I can think of one or two, but more importantly is that it would be a breaking change. It would be better to have an option to do what you want, for instance #16050.

I see, which particular feature would be broken? I'm guessing there is/are parts of the wallet that expect a call from notify?

On Fri, Jun 7, 2019, 02:29 João Barbosa notifications@github.com wrote:

I can think of one or two, but more importantly is that it would be a breaking change. It would be better to have an option to do what you want, for instance #16050 https://github.com/bitcoin/bitcoin/pull/16050.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/15781?email_source=notifications&email_token=AAIDAKN7WFBVS3V25C6RF2TPZFJR7A5CNFSM4HE2BVH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXDXSMY#issuecomment-499611955, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIDAKLAYNS43KC2KIOWRKTPZFJR7ANCNFSM4HE2BVHQ .

I mean it could break existing systems, not the wallet itself.

The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.