The merge below removed several instances of LOCK and LOCK2 some of which had braces for scope which now appear unused.
Remove braces previously used for locks #15783
pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:unused-braces changing 3 files +58 −68-
Bushstar commented at 1:32 PM on April 10, 2019: contributor
-
Remove curly braces previously used for locks c2146d437d
- fanquake added the label GUI on Apr 10, 2019
- fanquake added the label Refactoring on Apr 10, 2019
-
MarcoFalke commented at 1:38 PM on April 10, 2019: member
The changes look correct, but according to the guidelines I have to close this (c.f. the section on refactoring https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring and https://github.com/bitcoin/bitcoin/blob/master/.github/PULL_REQUEST_TEMPLATE.md and #15465)
Generally, if the style is not mentioned nor enforced by the developer notes, we leave it up to the original author to pick whatever fits them best personally and then leave it that way until the line is touched for other reasons.
- MarcoFalke closed this on Apr 10, 2019
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels