Gitian uses patched Boost improperly #1579

issue luke-jr opened this issue on July 11, 2012
  1. luke-jr commented at 8:44 AM on July 11, 2012: member

    Three problems:

    • boost-win32.yml doesn't work at all because the patch isn't indented
    • The #defines and #include should be moved to the relevant location in the Bitcoin code, not patched into the Boost dependency, or else native builds won't use the fix
    • gitian-win32.yml still references 1.47 for qmake instead of 1.49
  2. Diapolo commented at 9:29 AM on July 11, 2012: none

    I recently took a look at Boost 1.50, which was released a few days ago ... it seems they took a different approach to fix this. See: http://www.boost.org/doc/libs/1_50_0/doc/html/interprocess/acknowledgements_notes.html#interprocess.acknowledgements_notes.release_notes.release_notes_boost_1_50_00

    Seems with 1.50 we would need no monkey patches and I'm currently using it here.

  3. laanwj commented at 10:38 AM on July 11, 2012: member

    Yeah, getting rid of the monkey patch is even better.

  4. laanwj commented at 7:25 AM on September 21, 2012: member

    Closing this, boost 1.50 is now used

  5. laanwj closed this on Sep 21, 2012

  6. suprnurd referenced this in commit fe81d641da on Dec 5, 2017
  7. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me