Backport: [rpc] Remove the addresses field from the getaddressinfo return object #15800

1. 
   jnewbery commented at 7:56 PM on April 11, 2019: member

   Backport #15750

2. jnewbery renamed this:
   [rpc] Remove the addresses field from the getaddressinfo return object
   Backport: [rpc] Remove the addresses field from the getaddressinfo return object
   on Apr 11, 2019
3. meshcollider added the label Backport on Apr 11, 2019
4. meshcollider added this to the milestone 0.18.0 on Apr 11, 2019
5. meshcollider added the label RPC/REST/ZMQ on Apr 11, 2019
6. 
   MarcoFalke commented at 3:17 PM on April 15, 2019: member

   The backport should include the metadata. You may use a script to do it for you: https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport

7. 
   jnewbery commented at 3:42 PM on April 15, 2019: member

   Which metadata am I missing? I'd rather not do another merge resolve for this.

8. 
   MarcoFalke commented at 4:01 PM on April 15, 2019: member

   The backport should include the metadata:

   Github-Pull: #num
   Rebased-From: commit_id
   

   Of course, you can also add it manually

9. [rpc] Remove the addresses field from the getaddressinfo return object

   The "addresses" field was confusing because it refered to public keys
   using their P2PKH address.  It was included in the return object when
   needed for backward compatibility. Remove that compatibility now that
   the -deprecatedrpc=validateaddress option has been removed.
   
   New applications should use the 'embedded'->'address' field for P2SH or
   P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig
   participants.
   
   Github-Pull: 15750
   Rebased-From: b4338c151d4788c33f4b7c54daaf7f94b193a624

   b3a04c963d
10. 
    jnewbery commented at 4:19 PM on April 15, 2019: member

    Added metadata manually

11. jnewbery force-pushed on Apr 15, 2019
12. 
    MarcoFalke commented at 5:14 PM on April 15, 2019: member

    ACK b3a04c963d4e761b66a1a8c1aae1c835534e47eb (checked cherry-pick)

13. MarcoFalke merged this on Apr 15, 2019
14. MarcoFalke closed this on Apr 15, 2019

    ---

15. MarcoFalke referenced this in commit fa3993bfe8 on Apr 15, 2019
16. 
    MarcoFalke commented at 5:15 PM on April 15, 2019: member

    Merged. Please adjust the release notes (if necessary) https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft

17. 
    jnewbery commented at 5:47 PM on April 15, 2019: member

    Please adjust the release notes

    Done: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft/_compare/8469ba7665054b8066725dc41ceb0206d9a0bad5...74a36c9a0f5a45a7950f7e40d4de5cb3fcee42b3

18. jnewbery deleted the branch on Apr 15, 2019
19. DrahtBot locked this on Dec 16, 2021

Contributors

jnewberyMarcoFalke

Milestone
0.18.0