Fixes #15865
test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan #15866
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1904-testSync changing 1 files +4 −2-
MarcoFalke commented at 1:02 PM on April 22, 2019: member
-
test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan fa465e4da4
- fanquake added the label Tests on Apr 22, 2019
-
promag commented at 1:22 PM on April 22, 2019: member
Nice, I was going to pick this up.
-
DrahtBot commented at 7:31 PM on April 22, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15870 (wallet: Only fail rescan when blocks have actually been pruned by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
promag commented at 10:19 PM on April 22, 2019: member
So, IIUC,
syncwithvalidationinterfacequeue(sync_all->sync_mempools) is necessary to ensure that the wallet processed everything before callinglisttransactionsin L77.BTW restarted Appveyor.
utACK fa465e4da4c7242d7edd6339747572d23a39ff98.
- MarcoFalke referenced this in commit caceff5546 on Apr 23, 2019
- MarcoFalke merged this on Apr 23, 2019
- MarcoFalke closed this on Apr 23, 2019
- MarcoFalke deleted the branch on Apr 23, 2019
- jasonbcox referenced this in commit ed56d7f607 on Jul 16, 2020
- PastaPastaPasta referenced this in commit e9b0010a89 on Jun 27, 2021
- PastaPastaPasta referenced this in commit 542a8a0345 on Jun 28, 2021
- PastaPastaPasta referenced this in commit d3c248c14e on Jun 29, 2021
- linuxsh2 referenced this in commit 22962a6a70 on Aug 11, 2021
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels