Fix #15667
With this PR:
qt, wallet: Revamp SendConfirmationDialog #15886
pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:20190424-send-confirmation-dialog changing 2 files +29 −17-
hebasto commented at 8:48 PM on April 24, 2019: member
-
654e419549
Make SendConfirmationDialog fully fledged
The property-based API has been used. Added support for the `informativeText` and `detailedText` properties.
-
Show recipient list as detailedText of QMessageBox 2ee756f041
- DrahtBot added the label GUI on Apr 24, 2019
-
-
jonasschnelli commented at 6:59 AM on April 29, 2019: contributor
Nice work! I also wasn't aware of
QMessageBox::setDetailedText(). utACK 2ee756f0411c467fc638373ea68d6cb5ced46974 -
jonasschnelli commented at 11:07 AM on May 18, 2019: contributor
Tested a bit. I think the "show details..." approach should only appear if we have multiple recipients. But I'm open to be convinced otherwise.
-
hebasto commented at 7:11 PM on May 18, 2019: member
@promag @jonasschnelli Thank you for your reviews.
I think the "show details..." approach should only appear if we have multiple recipients.
Nice. Done.
- hebasto force-pushed on May 18, 2019
-
Do not show list for the only recipient. 78f9b5160f
- hebasto force-pushed on May 18, 2019
-
laanwj commented at 11:12 AM on June 6, 2019: member
code review ACK 78f9b5160fea32f85c6ced16b3b0cccda6d3b181
- laanwj merged this on Jun 6, 2019
- laanwj closed this on Jun 6, 2019
- laanwj referenced this in commit 9fccdd4ed4 on Jun 6, 2019
- hebasto deleted the branch on Jun 6, 2019
- sidhujag referenced this in commit 543f000a83 on Jun 6, 2019
- jasonbcox referenced this in commit 5cf11c4c87 on Sep 1, 2020
- deadalnix referenced this in commit 040710be6c on Sep 1, 2020
- deadalnix referenced this in commit a7c29026ca on Sep 1, 2020
- vijaydasmp referenced this in commit b9c0a56bf3 on Oct 23, 2021
- vijaydasmp referenced this in commit eb279ef2dd on Oct 26, 2021
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels